Verify critical edges when -sil-verify-all is enabled

Author: meg-gupta

lib/SILOptimizer/LoopTransforms/ArrayPropertyOpt.cpp

@@ -797,7 +797,8 @@ class SwiftArrayPropertyOptPass : public SILFunctionTransform {
         ArrayPropertiesSpecializer(DT, LA, HoistableLoopNest).run();
 
       // Verify that no illegal critical edges were created.
-      getFunction()->verifyCriticalEdges();
+      if (getFunction()->getModule().getOptions().VerifyAll)
+        getFunction()->verifyCriticalEdges();
 
       // We preserve the dominator tree. Let's invalidate everything
       // else.

lib/SILOptimizer/Transforms/SILMem2Reg.cpp

@@ -1032,7 +1032,8 @@ bool MemoryToRegisters::promoteSingleAllocation(AllocStackInst *alloc,
 bool MemoryToRegisters::run() {
   bool Changed = false;
 
-  F.verifyCriticalEdges();
+  if (F.getModule().getOptions().VerifyAll)
+    F.verifyCriticalEdges();
 
   // Compute dominator tree node levels for the function.
   DomTreeLevelMap DomTreeLevels;

lib/SILOptimizer/Transforms/SimplifyCFG.cpp

@@ -3372,7 +3372,9 @@ bool SimplifyCFG::run() {
     if (simplifyBlocks())
       removeUnreachableBlocks(Fn);
   }
-  Fn.verifyCriticalEdges();
+
+  if (Fn.getModule().getOptions().VerifyAll)
+    Fn.verifyCriticalEdges();
 
   // Canonicalize switch_enum instructions.
   Changed |= canonicalizeSwitchEnums();
@@ -4139,7 +4141,7 @@ class SplitCriticalEdges : public SILFunctionTransform {
   void run() override {
     auto &Fn = *getFunction();
 
-    if (OnlyNonCondBrEdges)
+    if (OnlyNonCondBrEdges && Fn.getModule().getOptions().VerifyAll)
       Fn.verifyCriticalEdges();
 
     // Split all critical edges from all or non only cond_br terminators.

lib/SILOptimizer/Utils/CheckedCastBrJumpThreading.cpp

@@ -657,7 +657,8 @@ void CheckedCastBrJumpThreading::optimizeFunction() {
     return;
 
   // Second phase: transformation.
-  Fn->verifyCriticalEdges();
+  if (Fn->getModule().getOptions().VerifyAll)
+    Fn->verifyCriticalEdges();
 
   for (Edit *edit : Edits) {
     BasicBlockCloner Cloner(edit->CCBBlock);