Skip to content

Commit 1fa23a6

Browse files
committed
Move an ineffective variable initialization to a where is has an effect
The original location was only invoked when build-script invked cmake and on top of that it did not actually make it into the cmake command line. Since build-script is running lit manually anyway, we can just move it over there.
1 parent 2ebd983 commit 1fa23a6

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

utils/build-script-impl

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2527,10 +2527,6 @@ for host in "${ALL_HOSTS[@]}"; do
25272527
-DLLDB_BUILD_FRAMEWORK:BOOL=TRUE
25282528
-DLLDB_CODESIGN_IDENTITY=""
25292529
)
2530-
if [[ "${ENABLE_ASAN}" ]] ; then
2531-
# Limit the number of parallel tests
2532-
LLVM_LIT_ARGS="${LLVM_LIT_ARGS} --threads=$(sysctl hw.physicalcpu | awk '{ print $2 }')"
2533-
fi
25342530
fi
25352531
fi
25362532
;;
@@ -3134,9 +3130,15 @@ for host in "${ALL_HOSTS[@]}"; do
31343130
# Prefer to use lldb-dotest, as building it guarantees that we build all
31353131
# test dependencies. Ultimately we want to delete as much lldb-specific logic
31363132
# from this file as possible and just have a single call to lldb-dotest.
3133+
3134+
if [[ "${ENABLE_ASAN}" ]] ; then
3135+
# Limit the number of parallel tests
3136+
LLVM_LIT_ARGS="${LLVM_LIT_ARGS} --threads=$(sysctl hw.physicalcpu | awk '{ print $2 }')"
3137+
fi
3138+
31373139
if [[ "$using_xcodebuild" == "FALSE" ]] ; then
31383140
with_pushd ${lldb_build_dir} \
3139-
call ${NINJA_BIN} unittests/LLDBUnitTests
3141+
call ${NINJA_BIN} unittests/LLDBUnitTests
31403142
with_pushd ${results_dir} \
31413143
call "${llvm_build_dir}/bin/llvm-lit" \
31423144
"${lldb_build_dir}/lit" \

0 commit comments

Comments
 (0)