[PropertyWrappers] Check for a generic constructor and also remove the extra 'hasParams' check

Author: theblixguy

lib/Sema/TypeCheckPropertyWrapper.cpp

@@ -208,24 +208,21 @@ static ConstructorDecl *findDefaultInit(ASTContext &ctx,
   nominal->lookupQualified(nominal, initName, NL_QualifiedDefault, decls);
   for (const auto &decl : decls) {
     auto init = dyn_cast<ConstructorDecl>(decl);
-    if (!init || init->getDeclContext() != nominal)
+    if (!init || init->getDeclContext() != nominal || init->isGeneric())
       continue;
 
+    assert(init->hasParameterList());
     // A constructor which does not have any parameters or where all the
     // parameters have a default argument can be used to default initialize
     // the property wrapper type.
-    assert(init->hasParameterList());
-    auto hasParams = init->getParameters()->size() > 0;
-    auto allParamsHaveDefaultArg = false;
-
-    if (hasParams) {
-      allParamsHaveDefaultArg = llvm::all_of(
-          init->getParameters()->getArray(),
-          [](const ParamDecl *decl) { return decl->isDefaultArgument(); });
-    }
-
-    // Skip synthesized default initializers
-    if (!hasParams || (allParamsHaveDefaultArg && !init->isImplicit())) {
+    //
+    // A constructor with no parameters will satisfy the check below.
+    bool allParamsHaveDefaultArg = llvm::all_of(
+        init->getParameters()->getArray(),
+        [](const ParamDecl *decl) { return decl->isDefaultArgument(); });
+
+    // Only add non-synthesized initializers.
+    if (allParamsHaveDefaultArg && !init->isImplicit()) {
       defaultValueInitializers.push_back(init);
     }
   }

test/SILOptimizer/di_property_wrappers_errors.swift

@@ -46,3 +46,23 @@ struct IntStructWithClassWrapper {
   } // expected-error{{return from initializer without initializing all stored properties}}
   // expected-note@-1{{'self.wrapped' not initialized}}  
 }
+
+// SR_11477
+
+@propertyWrapper
+struct SR_11477_W {
+  let name: String
+
+  init<T: ExpressibleByIntegerLiteral>(_ value: T = 0) {
+    self.name = "Init"
+  }
+
+  var wrappedValue: Int {
+    get { return 0 }
+  }
+}
+
+struct SR_11477_S {
+  @SR_11477_W var foo: Int
+  init() {} // expected-error {{return from initializer without initializing all stored properties}} expected-note {{'self.foo' not initialized}}
+}