Merge pull request #26965 from varungandhi-apple/vg-skip-module-trace-if-error

Skip module trace emission if we encountered errors when compiling.

Author: varungandhi-apple

lib/FrontendTool/FrontendTool.cpp

@@ -241,12 +241,15 @@ template <> struct ObjectTraits<LoadedModuleTraceFormat> {
 static bool emitLoadedModuleTraceIfNeeded(ModuleDecl *mainModule,
                                           DependencyTracker *depTracker,
                                           StringRef loadedModuleTracePath) {
+  ASTContext &ctxt = mainModule->getASTContext();
+  assert(!ctxt.hadError()
+         && "We may not be able to emit a proper trace if there was an error.");
+
   if (loadedModuleTracePath.empty())
     return false;
   std::error_code EC;
   llvm::raw_fd_ostream out(loadedModuleTracePath, EC, llvm::sys::fs::F_Append);
 
-  ASTContext &ctxt = mainModule->getASTContext();
   if (out.has_error() || EC) {
     ctxt.Diags.diagnose(SourceLoc(), diag::error_opening_output,
                         loadedModuleTracePath, EC.message());
@@ -271,7 +274,9 @@ static bool emitLoadedModuleTraceIfNeeded(ModuleDecl *mainModule,
     if (loadedDecl == mainModule)
       continue;
     assert(!loadedDecl->getModuleFilename().empty()
-           && "Don't know how to handle modules with empty names.");
+           && ("Don't know how to handle modules with empty names."
+               " One potential reason for getting an empty module name might"
+               " be that the module could not be deserialized correctly."));
     pathToModuleDecl.insert(
       std::make_pair(loadedDecl->getModuleFilename(), loadedDecl));
   }
@@ -1089,15 +1094,15 @@ static bool performCompile(CompilerInstance &Instance,
 
   emitReferenceDependenciesForAllPrimaryInputsIfNeeded(Invocation, Instance);
 
-  (void)emitLoadedModuleTraceForAllPrimariesIfNeeded(
-      Instance.getMainModule(), Instance.getDependencyTracker(), opts);
-
   if (Context.hadError()) {
     //  Emit the index store data even if there were compiler errors.
     (void)emitIndexData(Invocation, Instance);
     return true;
   }
 
+  (void)emitLoadedModuleTraceForAllPrimariesIfNeeded(
+      Instance.getMainModule(), Instance.getDependencyTracker(), opts);
+
   // FIXME: This is still a lousy approximation of whether the module file will
   // be externally consumed.
   bool moduleIsPublic =

test/Driver/Inputs/IllformedModule.swiftmodule

@@ -0,0 +1 @@
+// Placeholder text so that nobody accidentally deletes this when deleting empty files.

test/Driver/loaded_module_trace_skip.swift

@@ -0,0 +1,5 @@
+// rdar://problem/54860311.
+// RUN: not %target-typecheck-verify-swift -emit-loaded-module-trace -o %t/mytrace -I %S/Inputs 2>&1 | %FileCheck %s
+
+import IllformedModule
+// CHECK: unexpected error produced: malformed compiled module