Skip to content

Commit 23e5143

Browse files
authored
Merge pull request #60221 from eeckstein/unstable-benchmarks
benchmarks: fix some benchmark unstabilities
2 parents b6574b5 + 5c82b8c commit 23e5143

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

benchmark/single-source/ArrayAppend.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public let benchmarks = [
4545
setUpFunction: ones, tearDownFunction: releaseOnes, legacyFactor: 10),
4646
BenchmarkInfo(name: "ArrayAppendUTF16", runFunction: run_ArrayAppendUTF16, tags: t, legacyFactor: 34),
4747
BenchmarkInfo(name: "ArrayAppendUTF16Substring", runFunction: run_ArrayAppendUTF16Substring, tags: t, legacyFactor: 36),
48-
BenchmarkInfo(name: "ArrayPlusEqualArrayOfInt", runFunction: run_ArrayPlusEqualArrayOfInt, tags: t,
48+
BenchmarkInfo(name: "ArrayPlusEqualArrayOfInt", runFunction: run_ArrayPlusEqualArrayOfInt, tags: t + [.unstable],
4949
setUpFunction: ones, tearDownFunction: releaseOnes, legacyFactor: 10),
5050
BenchmarkInfo(name: "ArrayPlusEqualFiveElementCollection", runFunction: run_ArrayPlusEqualFiveElementCollection, tags: t, legacyFactor: 37),
5151
BenchmarkInfo(name: "ArrayPlusEqualSingleElementCollection", runFunction: run_ArrayPlusEqualSingleElementCollection, tags: t, legacyFactor: 47),

benchmark/single-source/SubstringTest.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public let benchmarks = [
2828
BenchmarkInfo(name: "SubstringEqualString", runFunction: run_SubstringEqualString, tags: [.validation, .api, .String]),
2929
BenchmarkInfo(name: "SubstringEquatable", runFunction: run_SubstringEquatable, tags: [.validation, .api, .String]),
3030
BenchmarkInfo(name: "SubstringFromLongString2", runFunction: run_SubstringFromLongString, tags: [.validation, .api, .String]),
31-
BenchmarkInfo(name: "SubstringFromLongStringGeneric", runFunction: run_SubstringFromLongStringGeneric, tags: [.validation, .api, .String]),
31+
BenchmarkInfo(name: "SubstringFromLongStringGeneric2", runFunction: run_SubstringFromLongStringGeneric, tags: [.validation, .api, .String]),
3232
BenchmarkInfo(name: "SubstringTrimmingASCIIWhitespace", runFunction: run_SubstringTrimmingASCIIWhitespace, tags: [.validation, .api, .String]),
3333
]
3434

@@ -58,7 +58,7 @@ func create<T : RangeReplaceableCollection, U : Collection>(
5858
public func run_SubstringFromLongStringGeneric(_ n: Int) {
5959
var s = longWide
6060
s += "!" // ensure the string has a real buffer
61-
for _ in 1...n*500 {
61+
for _ in 1...n*5000 {
6262
create(Substring.self, from: s)
6363
}
6464
}

0 commit comments

Comments
 (0)