Improve diagnostics

Co-authored-by: Richard Wei <[email protected]>

Author: asl

include/swift/AST/DiagnosticsSIL.def

@@ -608,7 +608,7 @@ NOTE(autodiff_cannot_differentiate_through_multiple_results,none,
 NOTE(autodiff_cannot_differentiate_through_inout_arguments,none,
      "cannot differentiate through 'inout' arguments", ())
 NOTE(autodiff_cannot_differentiate_through_direct_yield,none,
-     "cannot differentiate through a direct yield result", ())
+     "cannot differentiate through a '_read' accessor", ())
 NOTE(autodiff_enums_unsupported,none,
      "differentiating enum values is not yet supported", ())
 NOTE(autodiff_stored_property_parent_not_differentiable,none,

test/AutoDiff/SILOptimizer/activity_analysis.swift

@@ -594,7 +594,7 @@ struct HasCoroutineModifyAccessors: Differentiable {
 // expected-note @+1 {{when differentiating this function definition}}
 func testAccessorCoroutinesRead(_ x: HasCoroutineReadAccessors) -> Float {
   // We do not support differentiation of _read accessors
-  // expected-note @+1 {{cannot differentiate through a direct yield result}}
+  // expected-note @+1 {{cannot differentiate through a '_read' accessor}}
   return x.computed
 }
 

test/AutoDiff/SILOptimizer/differentiation_diagnostics.swift

@@ -826,7 +826,7 @@ struct HasModifyAccessors: Differentiable {
 // expected-note @+2 {{when differentiating this function definition}}
 @differentiable(reverse)
 func testReadAccessorCoroutines(_ x: HasReadAccessors) -> Float {
-  // expected-note @+1 {{cannot differentiate through a direct yield result}}
+  // expected-note @+1 {{cannot differentiate through a '_read' accessor}}
   return x.computed
 }