WIP

Author: tshortli

include/swift/AST/TypeCheckRequests.h

@@ -4426,7 +4426,7 @@ class SerializeAttrGenericSignatureRequest
 class IsFunctionBodySkippedRequest
     : public SimpleRequest<IsFunctionBodySkippedRequest,
                            bool(const AbstractFunctionDecl *),
-                           RequestFlags::Cached> {
+                           RequestFlags::SeparatelyCached> {
 public:
   using SimpleRequest::SimpleRequest;
 

include/swift/AST/TypeCheckerTypeIDZone.def

@@ -505,4 +505,4 @@ SWIFT_REQUEST(TypeChecker, SerializeAttrGenericSignatureRequest,
               Cached, NoLocationInfo)
 SWIFT_REQUEST(TypeChecker, IsFunctionBodySkippedRequest,
               bool(const AbstractFunctionDecl *),
-              Cached, NoLocationInfo)
+              SeparatelyCached, NoLocationInfo)

lib/AST/Decl.cpp

@@ -8966,7 +8966,8 @@ bool IsFunctionBodySkippedRequest::evaluate(
     if (AD->getAccessorKind() == AccessorKind::DidSet)
       return false;
 
-    // ALLANXXX explain, add test
+    // Synthesized accessors (like implicit _read or _modify accessors) need to
+    // be typechecked because they get serialized.
     if (AD->isSynthesized())
       return false;
   }

lib/SIL/IR/Linker.cpp

@@ -100,6 +100,8 @@ void SILLinkerVisitor::deserializeAndPushToWorklist(SILFunction *F) {
 /// Deserialize a function and add it to the worklist for processing.
 void SILLinkerVisitor::maybeAddFunctionToWorklist(SILFunction *F,
                                                   bool setToSerializable) {
+  PrettyStackTraceSILFunction stackTrace("adding to linker worklist", F);
+
   SILLinkage linkage = F->getLinkage();
   assert((!setToSerializable || F->hasValidLinkageForFragileRef() ||
          hasSharedVisibility(linkage)) &&