Skip to content

Commit 266365a

Browse files
committed
build-script fix for --extra-swift-args.
Passing an empty string to this option either as "--extra-swift-args=''" or "--extra-swift-args ''" would cause build-script-impl to fail to parse some arbitrary number of other options. This is impossible to debug from the build log because all of the build-script-impl options still show up in the log. So, cutting and pasting the build-script-impl command actually works. Turns out this is why build-script build and install stages never worked for me, beyond running cmake.
1 parent 3daf1c1 commit 266365a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

utils/build-script

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -763,8 +763,8 @@ class BuildScriptInvocation(object):
763763
# add them as one command.
764764
if args.extra_swift_args:
765765
impl_args += [
766-
"--extra-swift-args",
767-
";".join(args.extra_swift_args)]
766+
"--extra-swift-args=%s" % ';'.join(args.extra_swift_args)
767+
]
768768

769769
# If we have extra_cmake_options, combine all of them together and then
770770
# add them as one command.

0 commit comments

Comments
 (0)