Sema: bindExtensions() doesn't need to diagnose extensions right away

slavapestov · slavapestov · commit 26fddb7c6129 · 2018-09-19T09:47:36.000-07:00
We'll instead diagnose them when we type check their primary file,
since typeCheckDecl() calls validateExtension() whcih calls
bindExtension().
diff --git a/lib/Sema/TypeChecker.cpp b/lib/Sema/TypeChecker.cpp
@@ -467,10 +467,8 @@ static void bindExtensions(SourceFile &SF, TypeChecker &TC) {
     }
   } while(changed);
 
-  // Phase 3 - anything that remains on the worklist cannot be resolved, which
-  // means its invalid. Diagnose.
-  for (auto *ext : worklist)
-    bindExtensionDecl(ext, TC);
+  // Any remaining extensions are invalid. They will be diagnosed later by
+  // typeCheckDecl().
 }
 
 void TypeChecker::bindExtension(ExtensionDecl *ext) {

Original file line number	Diff line number	Diff line change
`@@ -467,10 +467,8 @@ static void bindExtensions(SourceFile &SF, TypeChecker &TC) {`
`467`	`467`	`}`
`468`	`468`	`} while(changed);`
`469`	`469`
`470`		`- // Phase 3 - anything that remains on the worklist cannot be resolved, which`
`471`		`- // means its invalid. Diagnose.`
`472`		`- for (auto *ext : worklist)`
`473`		`- bindExtensionDecl(ext, TC);`
	`470`	`+ // Any remaining extensions are invalid. They will be diagnosed later by`
	`471`	`+ // typeCheckDecl().`
`474`	`472`	`}`
`475`	`473`
`476`	`474`	`void TypeChecker::bindExtension(ExtensionDecl *ext) {`