Skip to content

Commit 2afcaa2

Browse files
committed
Update tests
1 parent a4861ef commit 2afcaa2

5 files changed

+10
-25
lines changed

test/Sema/accessibility_package_import_interface.swift

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,9 @@
1010
// RUN: -emit-module-interface-path %t/Dep.swiftinterface \
1111
// RUN: -emit-private-module-interface-path %t/Dep.private.swiftinterface
1212

13-
// TEST Dep private interface should contain the package name
14-
// RUN: %target-swift-typecheck-module-from-interface(%t/Dep.private.swiftinterface) -module-name Dep -I %t
15-
// RUN: %FileCheck %s --check-prefix=CHECK-DEP-PRIVATE < %t/Dep.private.swiftinterface
16-
// CHECK-DEP-PRIVATE: -package-name myPkg
17-
1813
// TEST Dep.swiftmodule should contain package name and package symbols
1914
// RUN: llvm-bcanalyzer --dump %t/Dep.swiftmodule | %FileCheck %s --check-prefix=CHECK-DEP-BC
20-
// CHECK-DEP-BC: <MODULE_PACKAGE_NAME abbrevid=6/> blob data = 'myPkg'
15+
// CHECK-DEP-BC: <MODULE_PACKAGE_NAME {{.*}}> blob data = 'myPkg'
2116

2217
// TEST Lib should load Dep.swiftmodule and access package decls if in the same package and error if not
2318
// RUN: %target-swift-frontend -typecheck %t/Lib.swift -package-name myPkg -I %t
@@ -39,9 +34,9 @@
3934
// RUN: -module-name Dep -I %t \
4035
// RUN: -o %t/Dep.swiftmodule
4136

42-
// TEST Dep binary built from interface should contain package name but no package symbols
37+
// TEST Dep binary built from interface should not contain package name or package symbols.
4338
// RUN: llvm-bcanalyzer --dump %t/Dep.swiftmodule | %FileCheck %s --check-prefix=CHECK-DEP-INTER-BC
44-
// CHECK-DEP-INTER-BC: <MODULE_PACKAGE_NAME abbrevid=7/> blob data = 'myPkg'
39+
// CHECK-DEP-INTER-BC-NOT: <MODULE_PACKAGE_NAME {{.*}}> blob data = 'myPkg'
4540

4641
// TEST Lib should error on loading Dep built from interface and accessing package symbols (unless usableFromInline or inlinable)
4742
// RUN: %target-swift-frontend -typecheck %t/Lib.swift -package-name myPkg -I %t -verify
@@ -109,16 +104,16 @@ public func publicFuncInlinable() {
109104
}
110105

111106
//--- Lib.swift
112-
import Dep // expected-error {{module 'Dep' is in package 'myPkg' but was built from a non-package interface; modules of the same package can only be loaded if built from source or package interface}}
107+
import Dep
113108

114109
public func libFunc() {
115110
publicFuncInlinable()
116111
publicFunc()
117-
packageFuncInlinable()
112+
packageFuncInlinable() // expected-error {{cannot find 'packageFuncInlinable' in scope; did you mean 'publicFuncInlinable'?}}
118113
packageFunc() // expected-error {{cannot find 'packageFunc' in scope}}
119-
let x = PackageKlassUFI()
114+
let x = PackageKlassUFI() // expected-error {{cannot find 'PackageKlassUFI' in scope}}
120115
let y = x.packageVarUFI
121-
let z = x.packageVar // expected-error {{value of type 'PackageKlassUFI' has no member 'packageVar'}}
116+
let z = x.packageVar
122117
print(x, y, z)
123118
}
124119

test/Sema/accessibility_package_inline_interface.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
// RUN: %FileCheck %s -check-prefix CHECK-UTILS < %t/Utils.swiftinterface
1212
// CHECK-UTILS: -module-name Utils
13-
// CHECK-UTILS: -package-name myLib
1413
// CHECK-UTILS: @usableFromInline
1514
// CHECK-UTILS: package class PackageKlassProto {
1615
// CHECK-UTILS: @usableFromInline

test/Sema/accessibility_package_interface.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
// CHECK-PUBLIC-UTILS-NOT: package class PackageKlass
1919
// CHECK-PUBLIC-UTILS-NOT: package var pkgVar
2020
// CHECK-PUBLIC-UTILS: -module-name Utils
21-
// CHECK-PUBLIC-UTILS: -package-name swift-utils.log
2221
// CHECK-PUBLIC-UTILS: public func publicFunc()
2322
// CHECK-PUBLIC-UTILS: @usableFromInline
2423
// CHECK-PUBLIC-UTILS: package func ufiPackageFunc()
@@ -39,7 +38,6 @@
3938
// CHECK-PRIVATE-UTILS-NOT: package class PackageKlass
4039
// CHECK-PRIVATE-UTILS-NOT: package var pkgVar
4140
// CHECK-PRIVATE-UTILS: -module-name Utils
42-
// CHECK-PRIVATE-UTILS: -package-name swift-utils.log
4341
// CHECK-PRIVATE-UTILS: public func publicFunc()
4442
// CHECK-PRIVATE-UTILS: @usableFromInline
4543
// CHECK-PRIVATE-UTILS: package func ufiPackageFunc()

test/Serialization/load_package_module.swift

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,10 @@
1919
// RUN: %target-swift-typecheck-module-from-interface(%t/LibInterface.swiftinterface) -I %t
2020
// RUN: %FileCheck %s --check-prefix=CHECK-PUBLIC < %t/LibInterface.swiftinterface
2121
// CHECK-PUBLIC: -module-name LibInterface
22-
// CHECK-PUBLIC: -package-name
2322

24-
// RUN: %target-swift-typecheck-module-from-interface(%t/LibInterface.private.swiftinterface) -module-name LibInterface -I %t
25-
// RUN: %FileCheck %s --check-prefix=CHECK-PRIVATE < %t/LibInterface.private.swiftinterface
26-
// CHECK-PRIVATE: -package-name libPkg
23+
// RUN: %target-swift-typecheck-module-from-interface(%t/LibInterface.private.swiftinterface) -module-name LibInterface -I %t -verify
2724

28-
// RUN: not %target-swift-frontend -typecheck %t/ClientLoadInterface.swift -package-name otherPkg -I %t 2> %t/resultX.output
29-
// RUN: %FileCheck %s -check-prefix CHECK-X < %t/resultX.output
30-
// CHECK-X: error: cannot find 'packageLog' in scope
25+
// RUN: %target-swift-frontend -typecheck %t/ClientLoadInterface.swift -package-name otherPkg -I %t -verify
3126

3227
// RUN: not %target-swift-frontend -typecheck %t/ClientLoadInterface.swift -package-name libPkg -I %t 2> %t/resultY.output
3328
// RUN: %FileCheck %s -check-prefix CHECK-Y < %t/resultY.output
@@ -45,7 +40,7 @@ import LibInterface
4540

4641
func someFunc() {
4742
publicLog(1)
48-
packageLog(2)
43+
packageLog(2) // expected-error {{cannot find 'packageLog' in scope}}
4944
}
5045

5146
//--- ClientLoadBinary.swift

test/Serialization/module_package_name.swift

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,10 @@
1111
// RUN: %target-swift-typecheck-module-from-interface(%t/Logging.swiftinterface) -I %t
1212
// RUN: %FileCheck %s --check-prefix=CHECK-PUBLIC < %t/Logging.swiftinterface
1313
// CHECK-PUBLIC: -module-name Logging
14-
// CHECK-PUBLIC: -package-name
1514

1615
// RUN: %target-swift-typecheck-module-from-interface(%t/Logging.private.swiftinterface) -module-name Logging -I %t
1716
// RUN: %FileCheck %s --check-prefix=CHECK-PRIVATE < %t/Logging.private.swiftinterface
1817
// CHECK-PRIVATE: -module-name Logging
19-
// CHECK-PRIVATE: -package-name MyLoggingPkg
2018

2119
//--- File.swift
2220
public func log(level: Int) {}

0 commit comments

Comments
 (0)