Skip to content

Commit 2b2c5dc

Browse files
committed
[NFC] Move findJobsToRecompileWhenNodesChange Into The Headers
So the compiler has a chance to see the definition for itself, rather than having to. manually force a specialization.
1 parent 9075d32 commit 2b2c5dc

File tree

2 files changed

+6
-20
lines changed

2 files changed

+6
-20
lines changed

include/swift/Driver/FineGrainedDependencyDriverGraph.h

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,12 @@ class ModuleDepGraph {
493493

494494
template <typename Nodes>
495495
std::vector<const driver::Job *>
496-
findJobsToRecompileWhenNodesChange(const Nodes &);
496+
findJobsToRecompileWhenNodesChange(const Nodes &nodes) {
497+
std::vector<ModuleDepGraphNode *> foundDependents;
498+
for (ModuleDepGraphNode *n : nodes)
499+
findPreviouslyUntracedDependents(foundDependents, n);
500+
return jobsContaining(foundDependents);
501+
}
497502

498503
private:
499504
std::vector<const driver::Job *>

lib/Driver/FineGrainedDependencyDriverGraph.cpp

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -156,25 +156,6 @@ std::vector<const Job *> ModuleDepGraph::findJobsToRecompileWhenWholeJobChanges(
156156
return findJobsToRecompileWhenNodesChange(allNodesInJob);
157157
}
158158

159-
template <typename Nodes>
160-
std::vector<const Job *>
161-
ModuleDepGraph::findJobsToRecompileWhenNodesChange(const Nodes &nodes) {
162-
std::vector<ModuleDepGraphNode *> foundDependents;
163-
for (ModuleDepGraphNode *n : nodes)
164-
findPreviouslyUntracedDependents(foundDependents, n);
165-
return jobsContaining(foundDependents);
166-
}
167-
168-
template std::vector<const Job *>
169-
ModuleDepGraph::findJobsToRecompileWhenNodesChange<
170-
std::unordered_set<ModuleDepGraphNode *>>(
171-
const std::unordered_set<ModuleDepGraphNode *> &);
172-
173-
template std::vector<const Job *>
174-
ModuleDepGraph::findJobsToRecompileWhenNodesChange<
175-
std::vector<ModuleDepGraphNode *>>(
176-
const std::vector<ModuleDepGraphNode *> &);
177-
178159
std::vector<std::string> ModuleDepGraph::computeSwiftDepsFromNodes(
179160
ArrayRef<const ModuleDepGraphNode *> nodes) const {
180161
llvm::StringSet<> swiftDepsOfNodes;

0 commit comments

Comments
 (0)