Merge pull request #79471 from rjmansfield/reorder-ctor-warning

tshortli · web-flow · commit 2d0f9779722d · 2025-02-23T18:45:18.000-08:00
Fix -Wreorder-ctor warning in DiagnosticVerifier.cpp.
diff --git a/lib/Frontend/DiagnosticVerifier.cpp b/lib/Frontend/DiagnosticVerifier.cpp
@@ -111,7 +111,7 @@ struct DiagLoc {
 
   DiagLoc(SourceManager &diagSM, SourceManager &verifierSM,
           SourceLoc initialSourceLoc, bool wantEnd = false)
-      : sourceLoc(initialSourceLoc), bufferID(std::nullopt), line(0), column(0)
+      : bufferID(std::nullopt), line(0), column(0), sourceLoc(initialSourceLoc)
   {
     if (sourceLoc.isInvalid())
       return;

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ struct DiagLoc {`
`111`	`111`
`112`	`112`	`DiagLoc(SourceManager &diagSM, SourceManager &verifierSM,`
`113`	`113`	`SourceLoc initialSourceLoc, bool wantEnd = false)`
`114`		`- : sourceLoc(initialSourceLoc), bufferID(std::nullopt), line(0), column(0)`
	`114`	`+ : bufferID(std::nullopt), line(0), column(0), sourceLoc(initialSourceLoc)`
`115`	`115`	`{`
`116`	`116`	`if (sourceLoc.isInvalid())`
`117`	`117`	`return;`