[cxx-interop][SwiftCompilerSources] Remove a workaround

The definition of `~BasicCalleeAnalysis` can now be inlined.

rdar://127152872 / resolves #64502

Author: egorzhdan

include/swift/SILOptimizer/Analysis/BasicCalleeAnalysis.h

@@ -37,7 +37,7 @@ class BasicCalleeAnalysis : public SILAnalysis {
   BasicCalleeAnalysis(SILModule *M)
       : SILAnalysis(SILAnalysisKind::BasicCallee), M(*M), Cache(nullptr) {}
 
-  ~BasicCalleeAnalysis();
+  ~BasicCalleeAnalysis() {}
 
   static bool classof(const SILAnalysis *S) {
     return S->getKind() == SILAnalysisKind::BasicCallee;

lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp

@@ -30,10 +30,6 @@
 
 using namespace swift;
 
-// TODO: can't be inlined to work around https://github.com/apple/swift/issues/64502
-BasicCalleeAnalysis::~BasicCalleeAnalysis() {
-}
-
 void BasicCalleeAnalysis::dump() const {
   print(llvm::errs());
 }