Skip to content

Commit 2d75074

Browse files
committed
[Refactoring] [test] Use more strict matching on returns and breaks
Make sure we match against an exact return or break in these cases, rather than a placeholder.
1 parent f5acd13 commit 2d75074

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

test/refactoring/ConvertAsync/convert_function.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ func asyncParams(arg: String, _ completion: (String?, Error?) -> Void) {
8787
// ASYNC-SIMPLE: func {{[a-zA-Z_]+}}(arg: String) async throws -> String {
8888
// ASYNC-SIMPLE-NEXT: let str = try await simpleErr(arg: arg)
8989
// ASYNC-SIMPLE-NEXT: print("simpleErr")
90-
// ASYNC-SIMPLE-NEXT: return str
90+
// ASYNC-SIMPLE-NEXT: {{^}}return str{{$}}
9191
// ASYNC-SIMPLE-NEXT: print("after")
9292
// ASYNC-SIMPLE-NEXT: }
9393

@@ -120,7 +120,7 @@ func asyncResNewErr(arg: String, _ completion: (Result<String, Error>) -> Void)
120120
// ASYNC-ERR-NEXT: do {
121121
// ASYNC-ERR-NEXT: let str = try await simpleErr(arg: arg)
122122
// ASYNC-ERR-NEXT: print("simpleErr")
123-
// ASYNC-ERR-NEXT: return str
123+
// ASYNC-ERR-NEXT: {{^}}return str{{$}}
124124
// ASYNC-ERR-NEXT: print("after")
125125
// ASYNC-ERR-NEXT: } catch let err {
126126
// ASYNC-ERR-NEXT: throw CustomError.Bad
@@ -142,11 +142,11 @@ func asyncUnhandledCompletion(_ completion: (String) -> Void) {
142142
// ASYNC-UNHANDLED: func asyncUnhandledCompletion() async -> String {
143143
// ASYNC-UNHANDLED-NEXT: let str = await simple()
144144
// ASYNC-UNHANDLED-NEXT: let success = run {
145-
// ASYNC-UNHANDLED-NEXT: <#completion#>(str)
146-
// ASYNC-UNHANDLED-NEXT: return true
145+
// ASYNC-UNHANDLED-NEXT: <#completion#>(str)
146+
// ASYNC-UNHANDLED-NEXT: {{^}} return true{{$}}
147147
// ASYNC-UNHANDLED-NEXT: }
148148
// ASYNC-UNHANDLED-NEXT: if !success {
149-
// ASYNC-UNHANDLED-NEXT: return "bad"
149+
// ASYNC-UNHANDLED-NEXT: {{^}} return "bad"{{$}}
150150
// ASYNC-UNHANDLED-NEXT: }
151151
// ASYNC-UNHANDLED-NEXT: }
152152

0 commit comments

Comments
 (0)