Nuke --build-serialized-stdlib-unittest build-script flag

Author: slavapestov

CMakeLists.txt

@@ -251,10 +251,6 @@ option(SWIFT_RUNTIME_CLOBBER_FREED_OBJECTS
     "Overwrite memory for deallocated Swift objects"
     "${SWIFT_RUNTIME_CLOBBER_FREED_OBJECTS_default}")
 
-option(SWIFT_SERIALIZE_STDLIB_UNITTEST
-    "Compile the StdlibUnittest module with -sil-serialize-all to increase the test coverage for the optimizer"
-    FALSE)
-
 option(SWIFT_STDLIB_SIL_DEBUGGING
     "Compile the Swift standard library with -gsil to enable debugging and profiling on SIL level"
     FALSE)
@@ -300,11 +296,6 @@ option(SWIFT_STDLIB_SIL_SERIALIZE_ALL
     "Build the standard libraries and overlays serializing all method bodies"
     TRUE)
 
-if(SWIFT_SERIALIZE_STDLIB_UNITTEST AND SWIFT_STDLIB_ENABLE_RESILIENCE)
-  message(WARNING "Ignoring SWIFT_SERIALIZE_STDLIB_UNITTEST because SWIFT_STDLIB_ENABLE_RESILIENCE is set")
-  set(SWIFT_SERIALIZE_STDLIB_UNITTEST FALSE)
-endif()
-
 if(SWIFT_STDLIB_SIL_SERIALIZE_ALL AND SWIFT_STDLIB_ENABLE_RESILIENCE)
   message(WARNING "Ignoring SWIFT_STDLIB_SIL_SERIALIZE_ALL because SWIFT_STDLIB_ENABLE_RESILIENCE is set")
   set(SWIFT_STDLIB_SIL_SERIALIZE_ALL FALSE)

stdlib/private/StdlibCollectionUnittest/CMakeLists.txt

@@ -1,7 +1,4 @@
 set(swift_stdlib_unittest_compile_flags)
-if(SWIFT_SERIALIZE_STDLIB_UNITTEST)
-  list(APPEND swift_stdlib_unittest_compile_flags "-Xfrontend" "-sil-serialize-all")
-endif()
 
 # TODO: support this on non-POSIX platforms.  It cannot be currently as it
 # depends on pthreads.

stdlib/private/StdlibUnicodeUnittest/CMakeLists.txt

@@ -1,7 +1,4 @@
 set(swift_stdlib_unittest_compile_flags)
-if(SWIFT_SERIALIZE_STDLIB_UNITTEST)
-  list(APPEND swift_stdlib_unittest_compile_flags "-Xfrontend" "-sil-serialize-all")
-endif()
 
 # TODO: support this on non-POSIX platforms.  It cannot be currently as it
 # depends on pthreads.

stdlib/private/StdlibUnittest/CMakeLists.txt

@@ -4,9 +4,6 @@ set(swift_stdlib_unittest_compile_flags
 if (SWIFT_RUNTIME_ENABLE_LEAK_CHECKER)
   list(APPEND swift_stdlib_unittest_compile_flags "-DSWIFT_RUNTIME_ENABLE_LEAK_CHECKER")
 endif()
-if(SWIFT_SERIALIZE_STDLIB_UNITTEST)
-  list(APPEND swift_stdlib_unittest_compile_flags "-Xfrontend" "-sil-serialize-all")
-endif()
 
 is_build_type_optimized("${SWIFT_STDLIB_BUILD_TYPE}" IS_BUILD_TYPE_OPTIMIZED)
 if (NOT IS_BUILD_TYPE_OPTIMIZED)

utils/build-presets.ini

@@ -134,7 +134,6 @@ dash-dash
 
 swift-stdlib-build-type=RelWithDebInfo
 swift-stdlib-enable-assertions=false
-build-serialized-stdlib-unittest
 
 [preset: mixin_buildbot_tools_R_stdlib_RD]
 mixin-preset=
@@ -149,7 +148,6 @@ dash-dash
 
 swift-stdlib-build-type=RelWithDebInfo
 swift-stdlib-enable-assertions=false
-build-serialized-stdlib-unittest
 
 [preset: mixin_buildbot_tools_RA_stdlib_DA]
 mixin-preset=
@@ -1471,7 +1469,6 @@ dash-dash
 
 swift-stdlib-build-type=RelWithDebInfo
 swift-stdlib-enable-assertions=false
-build-serialized-stdlib-unittest
 
 [preset: buildbot_incremental,tools=RA,stdlib=DA,test=macOS,type=device]
 mixin-preset=
@@ -1577,7 +1574,6 @@ dash-dash
 
 swift-stdlib-build-type=RelWithDebInfo
 swift-stdlib-enable-assertions=true
-build-serialized-stdlib-unittest
 
 #===------------------------------------------------------------------------===#
 # Swift Coverage Preset

utils/build-script-impl

@@ -172,7 +172,6 @@ KNOWN_SETTINGS=(
     build-swift-static-sdk-overlay    ""         "set to 1 to build static variants of the Swift SDK overlay"
     build-swift-examples        "1"              "set to 1 to build examples"
     build-swift-remote-mirror   "1"              "set to 1 to build the Swift Remote Mirror library"
-    build-serialized-stdlib-unittest "0"         "set to 1 to build the StdlibUnittest module with -sil-serialize-all"
     build-sil-debugging-stdlib  "0"              "set to 1 to build the Swift standard library with -gsil to enable debugging and profiling on SIL level"
     check-incremental-compilation "0"            "set to 1 to compile swift libraries multiple times to check if incremental compilation works"
     report-statistics           "0"              "set to 1 to generate compilation statistics files for swift libraries"
@@ -2173,7 +2172,6 @@ for host in "${ALL_HOSTS[@]}"; do
                     -DSWIFT_NATIVE_SWIFT_TOOLS_PATH:STRING="${native_swift_tools_path}"
                     -DSWIFT_INCLUDE_TOOLS:BOOL=$(true_false "${BUILD_SWIFT_TOOLS}")
                     -DSWIFT_BUILD_REMOTE_MIRROR:BOOL=$(true_false "${BUILD_SWIFT_REMOTE_MIRROR}")
-                    -DSWIFT_SERIALIZE_STDLIB_UNITTEST:BOOL=$(true_false "${BUILD_SERIALIZED_STDLIB_UNITTEST}")
                     -DSWIFT_STDLIB_SIL_DEBUGGING:BOOL=$(true_false "${BUILD_SIL_DEBUGGING_STDLIB}")
                     -DSWIFT_CHECK_INCREMENTAL_COMPILATION:BOOL=$(true_false "${CHECK_INCREMENTAL_COMPILATION}")
                     -DSWIFT_REPORT_STATISTICS:BOOL=$(true_false "${REPORT_STATISTICS}")