Apply suggestions from code review

oscbyspro · glessard · web-flow · commit 306eaefb5b0d · 2024-02-04T08:27:27.000+01:00
- Changed 128 integer literal to Int(Int8.max)+1 in unit tests (Int8.Stride is Int).

Co-authored-by: Guillaume Lessard &lt;glessard@users.noreply.github.com&gt;
diff --git a/test/stdlib/Integers.swift.gyb b/test/stdlib/Integers.swift.gyb
@@ -853,7 +853,7 @@ tests.test("Strideable") {
   expectEqual(dist(Int8.min, Int8.max), 255)
   expectEqual(dist(Int8.max, Int8.min), -255)
   
-  expectEqual(Int8.min.advanced(by: 128), 0)
+  expectEqual(Int8.min.advanced(by: Int(Int8.max)+1), 0)
   expectEqual(UInt.max.advanced(by: Int.min), UInt.max / 2)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -853,7 +853,7 @@ tests.test("Strideable") {`
`853`	`853`	`expectEqual(dist(Int8.min, Int8.max), 255)`
`854`	`854`	`expectEqual(dist(Int8.max, Int8.min), -255)`
`855`	`855`
`856`		`- expectEqual(Int8.min.advanced(by: 128), 0)`
	`856`	`+ expectEqual(Int8.min.advanced(by: Int(Int8.max)+1), 0)`
`857`	`857`	`expectEqual(UInt.max.advanced(by: Int.min), UInt.max / 2)`
`858`	`858`	`}`
`859`	`859`