swift-api-digester: keep track of all decl attribute kinds in module dump. (#18473)

The tool should use decl attribute kinds from AST rather than defining
its own list of attributes. Thus we can keep track of all attributes kinds
rather than the selected ones.

Author: nkcsgexi

include/swift/IDE/DigesterEnums.def

@@ -10,10 +10,6 @@
 #define NODE_ANNOTATION_CHANGE_KIND(NAME) NODE_ANNOTATION(NAME)
 #endif
 
-#ifndef DECL_ATTR
-#define DECL_ATTR(NAME)
-#endif
-
 #ifndef KEY
 #define KEY(NAME)
 #endif
@@ -96,9 +92,6 @@ NODE_ANNOTATION_CHANGE_KIND(Rename)
 // Keep type rewritten the last one.
 NODE_ANNOTATION_CHANGE_KIND(TypeRewritten)
 
-DECL_ATTR(deprecated)
-DECL_ATTR(fixedLayout)
-
 KEY(kind)
 KEY(name)
 KEY(selfIndex)
@@ -110,6 +103,7 @@ KEY(moduleName)
 KEY(throwing)
 KEY(mutating)
 KEY(static)
+KEY(deprecated)
 KEY(typeAttributes)
 KEY(declAttributes)
 KEY(declKind)
@@ -183,7 +177,6 @@ SPECIAL_CASE_ID(UIApplicationMain)
 #undef KNOWN_TYPE
 #undef KNOWN_PROTOCOL
 #undef KEY
-#undef DECL_ATTR
 #undef NODE_ANNOTATION_CHANGE_KIND
 #undef NODE_ANNOTATION
 #undef NODE_KIND

test/api-digester/Outputs/cake.json

@@ -34,7 +34,7 @@
         "P2"
       ],
       "declAttributes": [
-        "fixedLayout"
+        "FixedLayout"
       ],
       "children": [
         {
@@ -231,6 +231,9 @@
           "usr": "s:4cake2C1C3InsACSgXwvp",
           "location": "",
           "moduleName": "cake",
+          "declAttributes": [
+            "ReferenceOwnership"
+          ],
           "ownership": 1,
           "children": [
             {
@@ -246,6 +249,9 @@
               "usr": "s:4cake2C1C3InsACSgXwvg",
               "location": "",
               "moduleName": "cake",
+              "declAttributes": [
+                "Transparent"
+              ],
               "children": [
                 {
                   "kind": "TypeNominal",
@@ -271,6 +277,9 @@
               "usr": "s:4cake2C1C3InsACSgXwvs",
               "location": "",
               "moduleName": "cake",
+              "declAttributes": [
+                "Transparent"
+              ],
               "children": [
                 {
                   "kind": "TypeNominal",
@@ -303,6 +312,9 @@
           "usr": "s:4cake2C1C4Ins2ACXovp",
           "location": "",
           "moduleName": "cake",
+          "declAttributes": [
+            "ReferenceOwnership"
+          ],
           "ownership": 2,
           "children": [
             {
@@ -318,6 +330,9 @@
               "usr": "s:4cake2C1C4Ins2ACXovg",
               "location": "",
               "moduleName": "cake",
+              "declAttributes": [
+                "Transparent"
+              ],
               "children": [
                 {
                   "kind": "TypeNominal",
@@ -335,6 +350,9 @@
               "usr": "s:4cake2C1C4Ins2ACXovs",
               "location": "",
               "moduleName": "cake",
+              "declAttributes": [
+                "Transparent"
+              ],
               "children": [
                 {
                   "kind": "TypeNominal",
@@ -561,6 +579,9 @@
           "usr": "s:4cake6NumberO8rawValueACSgSi_tcfc",
           "location": "",
           "moduleName": "cake",
+          "declAttributes": [
+            "Inlinable"
+          ],
           "children": [
             {
               "kind": "TypeNominal",
@@ -607,6 +628,9 @@
               "usr": "s:4cake6NumberO8rawValueSivg",
               "location": "",
               "moduleName": "cake",
+              "declAttributes": [
+                "Inlinable"
+              ],
               "children": [
                 {
                   "kind": "TypeNominal",
@@ -687,7 +711,7 @@
         "CVarArg"
       ],
       "declAttributes": [
-        "fixedLayout"
+        "FixedLayout"
       ],
       "children": [
         {

test/api-digester/Outputs/clang-module-dump.txt

@@ -16,6 +16,9 @@
         "ObjcProt",
         "NSObjectProtocol"
       ],
+      "declAttributes": [
+        "ObjC"
+      ],
       "children": [
         {
           "kind": "Function",
@@ -25,6 +28,9 @@
           "usr": "c:objc(cs)ClangInterface(im)someFunction",
           "location": "",
           "moduleName": "Foo",
+          "declAttributes": [
+            "ObjC"
+          ],
           "children": [
             {
               "kind": "TypeNameAlias",
@@ -48,6 +54,10 @@
           "usr": "c:objc(cs)NSObject(im)init",
           "location": "",
           "moduleName": "Foo",
+          "declAttributes": [
+            "Override",
+            "ObjC"
+          ],
           "children": [
             {
               "kind": "TypeNominal",
@@ -67,6 +77,9 @@
       "usr": "c:objc(pl)ObjcProt",
       "location": "",
       "moduleName": "Foo",
+      "declAttributes": [
+        "ObjC"
+      ],
       "children": [
         {
           "kind": "Function",
@@ -76,6 +89,9 @@
           "usr": "c:objc(pl)ObjcProt(im)someFunctionFromProt",
           "location": "",
           "moduleName": "Foo",
+          "declAttributes": [
+            "ObjC"
+          ],
           "children": [
             {
               "kind": "TypeNameAlias",

test/api-digester/source-stability.swift

@@ -5,4 +5,4 @@
 // RUN: %api-digester -diagnose-sdk -input-paths %S/stdlib-stable.json -input-paths %t.tmp/current-stdlib.json >> %t.tmp/changes.txt
 // RUN: %clang -E -P -x c %S/source-stability.swift.expected -o - | sed '/^\s*$/d' > %t.tmp/source-stability.swift.expected
 // RUN: %clang -E -P -x c %t.tmp/changes.txt -o - | sed '/^\s*$/d' > %t.tmp/changes.txt.tmp
-// RUN: diff -u %t.tmp/source-stability.swift.expected %t.tmp/changes.txt.tmp ; rm -rf %S/tmp
+// RUN: diff -u %t.tmp/source-stability.swift.expected %t.tmp/changes.txt.tmp