Merge pull request #3929 from akyrtzi/fixcode-note-escaping

[FixCode] Make sure to accept the fixit in note about adding '@escapi…

Author: shahmishal

lib/FrontendTool/FrontendTool.cpp

@@ -601,6 +601,9 @@ class JSONFixitWriter : public DiagnosticConsumer {
         Info.ID == diag::convert_let_to_var.ID ||
         Info.ID == diag::parameter_extraneous_double_up.ID ||
         Info.ID == diag::attr_decl_attr_now_on_type.ID ||
+        Info.ID == diag::noescape_parameter.ID ||
+        Info.ID == diag::noescape_autoclosure.ID ||
+        Info.ID == diag::where_inside_brackets.ID ||
         Info.ID == diag::selector_construction_suggest.ID ||
         Info.ID == diag::selector_literal_deprecated_suggest.ID)
       return true;

test/FixCode/fixits-apply.swift

@@ -209,3 +209,15 @@ class NoSemi {
   enum Bar { case bar }
   var foo: .Bar = .bar
 }
+
+func fnWithClosure(c: @escaping ()->()) {}
+func testescape(rec: ()->()) {
+  fnWithClosure { rec() }
+}
+
+protocol Prot1 {}
+protocol Prot2 {
+  associatedtype Ty = Prot1
+}
+class Cls1 : Prot1 {}
+func testwhere<T: Prot2 where T.Ty == Cls1>(_: T) {}

test/FixCode/fixits-apply.swift.result

@@ -212,3 +212,15 @@ class NoSemi {
   enum Bar { case bar }
   var foo: .Bar = .bar
 }
+
+func fnWithClosure(c: @escaping ()->()) {}
+func testescape(rec: @escaping ()->()) {
+  fnWithClosure { rec() }
+}
+
+protocol Prot1 {}
+protocol Prot2 {
+  associatedtype Ty = Prot1
+}
+class Cls1 : Prot1 {}
+func testwhere<T: Prot2>(_: T) where T.Ty == Cls1 {}