Sema: DeclChecker::visitSubscriptDecl() does everything in the 'first pass'

slavapestov · slavapestov · commit 3355a7251f85 · 2018-03-22T17:47:57.000-07:00
diff --git a/lib/Sema/TypeCheckDecl.cpp b/lib/Sema/TypeCheckDecl.cpp
@@ -4268,13 +4268,12 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
 
   void visitSubscriptDecl(SubscriptDecl *SD) {
     if (!IsFirstPass) {
-      checkAccessControl(TC, SD);
       return;
     }
 
     TC.validateDecl(SD);
-
     TC.checkDeclAttributes(SD);
+    checkAccessControl(TC, SD);
   }
 
   void visitTypeAliasDecl(TypeAliasDecl *TAD) {

Original file line number	Diff line number	Diff line change
`@@ -4268,13 +4268,12 @@ class DeclChecker : public DeclVisitor<DeclChecker> {`
`4268`	`4268`
`4269`	`4269`	`void visitSubscriptDecl(SubscriptDecl *SD) {`
`4270`	`4270`	`if (!IsFirstPass) {`
`4271`		`- checkAccessControl(TC, SD);`
`4272`	`4271`	`return;`
`4273`	`4272`	`}`
`4274`	`4273`
`4275`	`4274`	`TC.validateDecl(SD);`
`4276`		`-`
`4277`	`4275`	`TC.checkDeclAttributes(SD);`
	`4276`	`+ checkAccessControl(TC, SD);`
`4278`	`4277`	`}`
`4279`	`4278`
`4280`	`4279`	`void visitTypeAliasDecl(TypeAliasDecl *TAD) {`