Skip to content

Commit 335a6c3

Browse files
authored
Merge pull request #7882 from gottesmm/coverage_fix
2 parents ef47c26 + e955e53 commit 335a6c3

File tree

2 files changed

+24
-25
lines changed

2 files changed

+24
-25
lines changed

utils/build-presets.ini

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1475,3 +1475,23 @@ dash-dash
14751475
swift-stdlib-build-type=RelWithDebInfo
14761476
swift-stdlib-enable-assertions=true
14771477
build-serialized-stdlib-unittest
1478+
1479+
#===------------------------------------------------------------------------===#
1480+
# Swift Coverage Preset
1481+
#===------------------------------------------------------------------------===#
1482+
1483+
[preset: buildbot_incremental,tools=RDA,stdlib=RDA,coverage]
1484+
build-subdir=buildbot_incremental_coverage
1485+
release-debuginfo
1486+
assertions
1487+
swift-analyze-code-coverage=not-merged
1488+
test
1489+
validation-test
1490+
skip-test-ios
1491+
skip-test-tvos
1492+
skip-test-watchos
1493+
skip-build-benchmark
1494+
verbose-build
1495+
lit-args=-v
1496+
reconfigure
1497+
build-ninja

utils/coverage/coverage-generate-data

Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,6 @@ def main():
194194
parser = argparse.ArgumentParser(
195195
description='Generate, parse test run profdata')
196196
parser.add_argument('swift_dir', metavar='swift-dir')
197-
parser.add_argument('--build-dir')
198-
parser.add_argument('--build-subdir', default='coverage')
199197
parser.add_argument('--log',
200198
help='the level of information to log (default: info)',
201199
metavar='LEVEL',
@@ -208,36 +206,17 @@ def main():
208206
logging.debug(args)
209207

210208
swift_dir = os.path.realpath(os.path.abspath(args.swift_dir))
211-
if args.build_dir:
212-
build_dir = os.path.realpath(os.path.abspath(args.build_dir))
213-
else:
214-
build_dir = os.path.realpath(os.path.join(os.path.dirname(swift_dir),
215-
'build'))
216-
build_subdir = os.path.join(build_dir, args.build_subdir)
209+
build_dir = os.path.realpath(os.path.join(os.path.dirname(swift_dir),
210+
'build'))
211+
build_subdir = os.path.join(build_dir, 'buildbot_incremental_coverage')
217212

218213
global_build_subdir = build_subdir
219214

220215
build_script_cmd = [
221216
os.path.join(swift_dir, 'utils/build-script'),
222-
'--release',
223-
'--no-assertions',
224-
'--swift-analyze-code-coverage', 'not-merged',
225-
'--test',
226-
'--validation-test',
227-
'--skip-test-ios',
228-
'--skip-test-tvos',
229-
'--skip-test-watchos',
230-
'--skip-build-benchmark',
231-
'--verbose-build',
232-
'--lit-args=-v',
233-
'--reconfigure',
234-
'--build-ninja',
235-
'--build-subdir', build_subdir
217+
'--preset=buildbot_incremental,tools=RDA,stdlib=RDA,coverage',
236218
]
237219

238-
if args.build_dir:
239-
build_script_cmd += ['--build-dir', build_dir]
240-
241220
call(build_script_cmd)
242221

243222
assert global_build_subdir

0 commit comments

Comments
 (0)