[SE-0258] Add a Fix-It for the value -> wrappedValue rename.

DougGregor · DougGregor · commit 339d3c2b4255 · 2019-06-14T13:41:26.000-07:00
(cherry picked from commit 99d42c4)
diff --git a/lib/Sema/TypeCheckPropertyWrapper.cpp b/lib/Sema/TypeCheckPropertyWrapper.cpp
@@ -261,7 +261,8 @@ PropertyWrapperTypeInfoRequest::evaluate(
       return PropertyWrapperTypeInfo();
     }
 
-    valueVar->diagnose(diag::property_wrapper_value);
+    valueVar->diagnose(diag::property_wrapper_value)
+      .fixItReplace(valueVar->getNameLoc(), "wrappedValue");
   }
 
   PropertyWrapperTypeInfo result;
diff --git a/test/decl/var/property_wrapper_aliases.swift b/test/decl/var/property_wrapper_aliases.swift
@@ -26,7 +26,7 @@ struct Wrapper<T> {
 
 @propertyWrapper
 struct OldValue<T> {
-  var value: T // expected-warning{{property wrapper's `value` property should be renamed to 'wrappedValue'; use of 'value' is deprecated}}
+  var value: T // expected-warning{{property wrapper's `value` property should be renamed to 'wrappedValue'; use of 'value' is deprecated}}{{7-12=wrappedValue}}
 }
 
 struct TestOldValue {

Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,8 @@ PropertyWrapperTypeInfoRequest::evaluate(`
`261`	`261`	`return PropertyWrapperTypeInfo();`
`262`	`262`	`}`
`263`	`263`
`264`		`- valueVar->diagnose(diag::property_wrapper_value);`
	`264`	`+ valueVar->diagnose(diag::property_wrapper_value)`
	`265`	`+ .fixItReplace(valueVar->getNameLoc(), "wrappedValue");`
`265`	`266`	`}`
`266`	`267`
`267`	`268`	`PropertyWrapperTypeInfo result;`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ struct Wrapper<T> {`
`26`	`26`
`27`	`27`	`@propertyWrapper`
`28`	`28`	`struct OldValue<T> {`
`29`		- var value: T // expected-warning{{property wrapper's `value` property should be renamed to 'wrappedValue'; use of 'value' is deprecated}}
	`29`	+ var value: T // expected-warning{{property wrapper's `value` property should be renamed to 'wrappedValue'; use of 'value' is deprecated}}{{7-12=wrappedValue}}
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`struct TestOldValue {`