Add precondition that no repairs were made to _mangledTypeName string

ktoso · ktoso · commit 34b6e4fe5895 · 2020-03-18T11:51:28.000+09:00
diff --git a/stdlib/public/core/Misc.swift b/stdlib/public/core/Misc.swift
@@ -92,8 +92,12 @@ func _mangledTypeName<T>(_ type: T.Type) -> String? {
     return nil
   }
 
-  return String._fromUTF8Repairing(
-      UnsafeBufferPointer(start: stringPtr, count: count)).0
+  let (result, repairsMade) = String._fromUTF8Repairing(
+      UnsafeBufferPointer(start: stringPtr, count: count))
+
+  precondition(!repairsMade, "repairs made to _mangledTypeName, this is not expected since names should always valid UTF-8")
+
+  return result
 }
 
 /// Lookup a class given a name. Until the demangled encoding of type

Original file line number	Diff line number	Diff line change
`@@ -92,8 +92,12 @@ func _mangledTypeName<T>(_ type: T.Type) -> String? {`
`92`	`92`	`return nil`
`93`	`93`	`}`
`94`	`94`
`95`		`- return String._fromUTF8Repairing(`
`96`		`- UnsafeBufferPointer(start: stringPtr, count: count)).0`
	`95`	`+ let (result, repairsMade) = String._fromUTF8Repairing(`
	`96`	`+ UnsafeBufferPointer(start: stringPtr, count: count))`
	`97`	`+`
	`98`	`+ precondition(!repairsMade, "repairs made to _mangledTypeName, this is not expected since names should always valid UTF-8")`
	`99`	`+`
	`100`	`+ return result`
`97`	`101`	`}`
`98`	`102`
`99`	`103`	`/// Lookup a class given a name. Until the demangled encoding of type`