Merge pull request #35592 from rintaro/5.4-parse-rdar73159041

[5.4][Parse] Diagnose default argument for subscript in protocols

Author: rintaro

include/swift/AST/DiagnosticsParse.def

@@ -790,6 +790,8 @@ ERROR(protocol_method_argument_init,none,
       "default argument not permitted in a protocol method", ())
 ERROR(protocol_init_argument_init,none,
       "default argument not permitted in a protocol initializer", ())
+ERROR(protocol_subscript_argument_init,none,
+      "default argument not permitted in a protocol subscript", ())
 ERROR(tuple_type_multiple_labels,none,
       "tuple element cannot have two labels", ())
 

lib/Parse/ParseDecl.cpp

@@ -7366,6 +7366,12 @@ Parser::parseDeclSubscript(SourceLoc StaticLoc,
 
   diagnoseWhereClauseInGenericParamList(GenericParams);
 
+  // Protocol requirement arguments may not have default values.
+  if (Flags.contains(PD_InProtocol) && DefaultArgs.HasDefaultArgument) {
+    diagnose(SubscriptLoc, diag::protocol_subscript_argument_init);
+    return nullptr;
+  }
+
   // Build an AST for the subscript declaration.
   DeclName name = DeclName(Context, DeclBaseName::createSubscript(),
                            argumentNames);

test/decl/protocol/protocol_with_default_args.swift

@@ -11,4 +11,5 @@ struct X : P {
 
 protocol Q {
   init(truth: Bool = false) // expected-error{{default argument not permitted in a protocol initializer}}
+  subscript(x: Int, default: Int = 0) -> Self { get } // expected-error {{default argument not permitted in a protocol subscript}}
 }