Skip to content

Commit 3798bed

Browse files
authored
Merge pull request #14472 from compnerd/driver-break-return
Driver: avoid unnecessary break after return in switch
2 parents fbaaa75 + b49d69f commit 3798bed

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

lib/Driver/Driver.cpp

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -212,23 +212,16 @@ Driver::buildToolChain(const llvm::opt::InputArgList &ArgList) {
212212
case llvm::Triple::TvOS:
213213
case llvm::Triple::WatchOS:
214214
return llvm::make_unique<toolchains::Darwin>(*this, target);
215-
break;
216215
case llvm::Triple::Linux:
217-
if (target.isAndroid()) {
216+
if (target.isAndroid())
218217
return llvm::make_unique<toolchains::Android>(*this, target);
219-
} else {
220-
return llvm::make_unique<toolchains::GenericUnix>(*this, target);
221-
}
222-
break;
218+
return llvm::make_unique<toolchains::GenericUnix>(*this, target);
223219
case llvm::Triple::FreeBSD:
224220
return llvm::make_unique<toolchains::GenericUnix>(*this, target);
225-
break;
226221
case llvm::Triple::Win32:
227222
return llvm::make_unique<toolchains::Cygwin>(*this, target);
228-
break;
229223
case llvm::Triple::Haiku:
230224
return llvm::make_unique<toolchains::GenericUnix>(*this, target);
231-
break;
232225
default:
233226
Diags.diagnose(SourceLoc(), diag::error_unknown_target,
234227
ArgList.getLastArg(options::OPT_target)->getValue());

0 commit comments

Comments
 (0)