NOTE should actually be a WARNING.

Updating test as well to check that the fix-it is applied correctly.

Author: vguerra

include/swift/AST/DiagnosticsCommon.def

@@ -54,7 +54,7 @@ NOTE(previous_decldef,none,
 NOTE(brace_stmt_suggest_do,none,
      "did you mean to use a 'do' statement?", ())
 
-NOTE(defer_stmt_at_block_end,none,
+WARNING(defer_stmt_at_block_end,none,
      "'defer' at the end of its scope is redundant and will execute immediately; "
      "replace it with 'do'", ())
 

test/Sema/diag_defer_block_end.swift

@@ -3,14 +3,14 @@
 let x = 1
 let y = 2
 if (x > y) {
-    defer { // expected-note {{'defer' at the end of its scope is redundant and will execute immediately}}
+    defer { // expected-warning {{'defer' at the end of its scope is redundant and will execute immediately}}{{5-10=do}}
         print("not so useful defer stmt.")
     }
 }
 
 func sr7307(_ value: Bool) {
     let negated = !value 
-    defer { // expected-note {{'defer' at the end of its scope is redundant and will execute immediately}}
+    defer { // expected-warning {{'defer' at the end of its scope is redundant and will execute immediately}}{{5-10=do}}
         print("negated value is {negated}")
     }
 }