Move some tests into our testsuite and various other fixes

Author: Azoy

stdlib/public/Reflection/Package.swift

@@ -29,17 +29,19 @@ public struct Case {
 
   @inlinable
   public init?(from instance: Any) {
-    guard Type(instance).isEnum else {
+    let instanceTy = type(of: instance)
+
+    guard Type(instanceTy).isEnum else {
       return nil
     }
 
     var container = unsafeBitCast(instance, to: AnyExistentialContainer.self)
 
     let tag = container.projectValue {
-      Metadata(type(of: instance)).enum.enumVWT.getEnumTag($0)
+      Metadata(instanceTy).enum.enumVWT.getEnumTag($0)
     }
 
-    self.parent = Metadata(type(of: instance)).enum
+    self.parent = Metadata(instanceTy).enum
     self.tag = Int(truncatingIfNeeded: tag)
   }
 }

stdlib/public/Reflection/README.md

@@ -42,8 +42,7 @@ extension Field {
   @inlinable
   public var name: String {
     guard parent.kind != .tuple else {
-      //return TupleMetadata(parent.ptr).elements[index].
-      return "hello"
+      return parent.tuple.elements[index].label
     }
 
     return parent.type.descriptor.fields[index].name

stdlib/public/Reflection/Sources/Reflection/Case.swift

@@ -128,7 +128,7 @@ extension ValueWitnessTable {
     _ dest: UnsafeMutableRawPointer,
     _ src: UnsafeRawPointer
   ) -> UnsafeMutableRawPointer {
-    let address = layout.raw
+    let address = address(for: \.initializeBufferWithCopyOfBuffer)
 
     return address.signedVWTInitializeBufferWithCopyOfBuffer(
       dest,
@@ -139,17 +139,7 @@ extension ValueWitnessTable {
 
   @inlinable
   public func destroy(_ src: UnsafeMutableRawPointer) {
-    // rdar://103834325
-    // FIXME: There's currently a compiler bug preventing me from doing:
-    // 'address(of: \.destroy)'
-    // or even
-    // 'MemoryLayout<ValueWitnessTable.Layout.Pointee>.offset(of: \.destroy)'
-    //
-    // The same goes for everything else in this file
-    let address = layout.raw
-                  + MemoryLayout<InitializeBufferWithCopyOfBuffer>.size
-    
-    address.signedVWTDestroy(src, trailing)
+    address(for: \.destroy).signedVWTDestroy(src, trailing)
   }
 
   @inlinable
@@ -158,9 +148,7 @@ extension ValueWitnessTable {
     _ dest: UnsafeMutableRawPointer,
     _ src: UnsafeRawPointer
   ) -> UnsafeMutableRawPointer {
-    let address = layout.raw
-                  + MemoryLayout<InitializeBufferWithCopyOfBuffer>.size
-                  + MemoryLayout<Destroy>.size
+    let address = address(for: \.initializeWithCopy)
 
     return address.signedVWTInitializeWithCopy(dest, src, trailing)
   }
@@ -171,10 +159,7 @@ extension ValueWitnessTable {
     _ dest: UnsafeMutableRawPointer,
     _ src: UnsafeRawPointer
   ) -> UnsafeMutableRawPointer {
-    let address = layout.raw
-                  + MemoryLayout<InitializeBufferWithCopyOfBuffer>.size
-                  + MemoryLayout<Destroy>.size
-                  + MemoryLayout<InitializeWithCopy>.size
+    let address = address(for: \.assignWithCopy)
 
     return address.signedVWTAssignWithCopy(dest, src, trailing)
   }
@@ -185,11 +170,7 @@ extension ValueWitnessTable {
     _ dest: UnsafeMutableRawPointer,
     _ src: UnsafeMutableRawPointer
   ) -> UnsafeMutableRawPointer {
-    let address = layout.raw
-                  + MemoryLayout<InitializeBufferWithCopyOfBuffer>.size
-                  + MemoryLayout<Destroy>.size
-                  + MemoryLayout<InitializeWithCopy>.size
-                  + MemoryLayout<AssignWithCopy>.size
+    let address = address(for: \.initializeWithTake)
 
     return address.signedVWTInitializeWithTake(dest, src, trailing)
   }
@@ -200,12 +181,7 @@ extension ValueWitnessTable {
     _ dest: UnsafeMutableRawPointer,
     _ src: UnsafeMutableRawPointer
   ) -> UnsafeMutableRawPointer {
-    let address = layout.raw
-                  + MemoryLayout<InitializeBufferWithCopyOfBuffer>.size
-                  + MemoryLayout<Destroy>.size
-                  + MemoryLayout<InitializeWithCopy>.size
-                  + MemoryLayout<AssignWithCopy>.size
-                  + MemoryLayout<InitializeWithTake>.size
+    let address = address(for: \.assignWithTake)
 
     return address.signedVWTAssignWithTake(dest, src, trailing)
   }
@@ -216,13 +192,7 @@ extension ValueWitnessTable {
     _ src: UnsafeRawPointer,
     _ numberOfEmptyCases: UInt32
   ) -> UInt32 {
-    let address = layout.raw
-                  + MemoryLayout<InitializeBufferWithCopyOfBuffer>.size
-                  + MemoryLayout<Destroy>.size
-                  + MemoryLayout<InitializeWithCopy>.size
-                  + MemoryLayout<AssignWithCopy>.size
-                  + MemoryLayout<InitializeWithTake>.size
-                  + MemoryLayout<AssignWithTake>.size
+    let address = address(for: \.getEnumTagSinglePayload)
 
     return address.signedVWTGetEnumTagSinglePayload(
       src,
@@ -237,14 +207,7 @@ extension ValueWitnessTable {
     _ tag: UInt32,
     _ numberOfEmptyCases: UInt32
   ) -> () {
-    let address = layout.raw
-                  + MemoryLayout<InitializeBufferWithCopyOfBuffer>.size
-                  + MemoryLayout<Destroy>.size
-                  + MemoryLayout<InitializeWithCopy>.size
-                  + MemoryLayout<AssignWithCopy>.size
-                  + MemoryLayout<InitializeWithTake>.size
-                  + MemoryLayout<AssignWithTake>.size
-                  + MemoryLayout<GetEnumTagSinglePayload>.size
+    let address = address(for: \.storeEnumTagSinglePayload)
 
     return address.signedVWTStoreEnumTagSinglePayload(
       src,

stdlib/public/Reflection/Sources/Reflection/Field.swift

@@ -43,6 +43,8 @@ class Lock<T> {
       UnsafeRawPointer.self
     )
 
+    lock.value = initialValue
+
     _lockInit(lock.mutex)
 
     return lock