Skip to content

Commit 398ded5

Browse files
committed
Remove hardcode to emit types in CompilerSwiftSyntax with ABI mod name
Now that mangling for the debugger respects originally defined in, this is not needed anymore.
1 parent d75bde3 commit 398ded5

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

lib/AST/ASTMangler.cpp

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2591,15 +2591,9 @@ void ASTMangler::appendModule(const ModuleDecl *module,
25912591
StringRef ModName = module->getRealName().str();
25922592

25932593
// If RespectOriginallyDefinedIn is not set, ignore the ABI name only for
2594-
// _Concurrency and swift-syntax (which adds "Compiler" as a prefix when
2595-
// building swift-syntax as part of the compiler).
2596-
// TODO: Mangling for the debugger should respect originally defined in, but
2597-
// as of right now there is not enough information in the mangled name to
2598-
// reconstruct AST types from mangled names when using that attribute.
2594+
// _Concurrency.
25992595
if ((RespectOriginallyDefinedIn ||
2600-
(module->getName().str() != SWIFT_CONCURRENCY_NAME &&
2601-
!module->getABIName().str().starts_with(
2602-
SWIFT_MODULE_ABI_NAME_PREFIX))) &&
2596+
module->getName().str() != SWIFT_CONCURRENCY_NAME) &&
26032597
module->getABIName() != module->getName())
26042598
ModName = module->getABIName().str();
26052599

0 commit comments

Comments
 (0)