Skip to content

Commit 39aef7d

Browse files
authored
Merge pull request #62446 from drexin/wip-103080745
[Build] Pass missing build parameters
2 parents a06b86b + 2bac2a1 commit 39aef7d

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

utils/swift_build_support/swift_build_support/build_script_invocation.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,11 @@ def convert_to_impl_arguments(self):
176176
product_name, ' '.join(cmake_opts))
177177
]
178178

179+
if args.build_toolchain_only:
180+
impl_args += [
181+
"--build-toolchain-only=1"
182+
]
183+
179184
if args.build_stdlib_deployment_targets:
180185
impl_args += [
181186
"--build-stdlib-deployment-targets", " ".join(

utils/swift_build_support/swift_build_support/products/cmake_product.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,15 @@ def build_with_cmake(self, build_targets, build_type, build_args,
9191
shell.call(["env"] + cmake_build + cmake_opts)
9292

9393
shell.call(
94-
["env"] + cmake_build + cmake_opts + ["--"] + build_args + build_targets
94+
["env"] + cmake_build + cmake_opts + ["--"] + build_args
95+
+ _cmake.build_args() + build_targets
9596
)
9697

9798
def test_with_cmake(self, executable_target, results_targets,
9899
build_type, build_args, test_env=None):
99100
assert self.toolchain.cmake is not None
100101
cmake_build = []
102+
_cmake = cmake.CMake(self.args, self.toolchain)
101103

102104
if self.toolchain.distcc_pump:
103105
cmake_build.append(self.toolchain.distcc_pump)
@@ -110,7 +112,7 @@ def test_with_cmake(self, executable_target, results_targets,
110112

111113
cmake_args = [self.toolchain.cmake, "--build", self.build_dir,
112114
"--config", build_type, "--"]
113-
cmake_build.extend(cmake_args + build_args)
115+
cmake_build.extend(cmake_args + build_args + _cmake.build_args())
114116

115117
def target_flag(target):
116118
if self.args.cmake_generator == "Xcode":

validation-test/BuildSystem/skip_build_xcode.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@
1111
#
1212
# CHECK: --- Building llvm ---
1313
# CHECK: env {{.+}}/cmake --build {{.+}}/Xcode-ReleaseAssert/llvm-macosx-{{.+}} --config Release --target ZERO_CHECK{{$}}
14-
# CHECK-NEXT: env {{.+}}/cmake --build {{.+}}/Xcode-ReleaseAssert/llvm-macosx-{{.+}} --config Release --target ZERO_CHECK -- -target llvm-tblgen -target clang-resource-headers -target intrinsics_gen -target clang-tablegen-targets -target FileCheck -target not -target llvm-nm -target llvm-size{{$}}
14+
# CHECK-NEXT: env {{.+}}/cmake --build {{.+}}/Xcode-ReleaseAssert/llvm-macosx-{{.+}} --config Release --target ZERO_CHECK -- {{.*}}-target llvm-tblgen -target clang-resource-headers -target intrinsics_gen -target clang-tablegen-targets -target FileCheck -target not -target llvm-nm -target llvm-size{{$}}

0 commit comments

Comments
 (0)