Sema: Fix a crasher by removing TVO_CanBindToInOut in a couple of spots

Author: slavapestov

lib/Sema/CSGen.cpp

@@ -2602,7 +2602,7 @@ namespace {
 
     Type visitDiscardAssignmentExpr(DiscardAssignmentExpr *expr) {
       auto locator = CS.getConstraintLocator(expr);
-      auto typeVar = CS.createTypeVariable(locator, TVO_CanBindToInOut);
+      auto typeVar = CS.createTypeVariable(locator, /*options=*/0);
       return LValueType::get(typeVar);
     }
 
@@ -2616,10 +2616,9 @@ namespace {
       auto destTy = CS.computeAssignDestType(expr->getDest(), expr->getLoc());
       if (!destTy)
         return Type();
-      if (destTy->getRValueType()->is<UnresolvedType>()) {
+      if (destTy->is<UnresolvedType>()) {
         return CS.createTypeVariable(CS.getConstraintLocator(expr),
-                                     TVO_CanBindToLValue |
-                                     TVO_CanBindToInOut);
+                                     /*options=*/0);
       }
 
       // The source must be convertible to the destination.

validation-test/compiler_crashers/28626-objectty-is-lvaluetype-objectty-is-inouttype-cannot-have-inout-or-lvalue-wrapped.swift renamed to validation-test/compiler_crashers_fixed/28626-objectty-is-lvaluetype-objectty-is-inouttype-cannot-have-inout-or-lvalue-wrapped.swift

@@ -5,6 +5,6 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 // REQUIRES: asserts
 &[_=(&_