[cxx-interop] Re-order operators.

Re-order operator case statements and tests. The order now follows the order defined in `llvm-project/clang/include/clang/Basic/OperatorKinds.def`.

Also, adds operator character(s) in parentheses.

Author: zoecarver

lib/ClangImporter/ImportName.cpp

@@ -1426,16 +1426,16 @@ ImportedName NameImporter::importNameImpl(const clang::NamedDecl *D,
     case clang::OverloadedOperatorKind::OO_Percent:
     case clang::OverloadedOperatorKind::OO_Amp:
     case clang::OverloadedOperatorKind::OO_Pipe:
-    case clang::OverloadedOperatorKind::OO_LessLess:
-    case clang::OverloadedOperatorKind::OO_GreaterGreater:
-    case clang::OverloadedOperatorKind::OO_AmpAmp:
-    case clang::OverloadedOperatorKind::OO_PipePipe:
     case clang::OverloadedOperatorKind::OO_Less:
     case clang::OverloadedOperatorKind::OO_Greater:
+    case clang::OverloadedOperatorKind::OO_LessLess:
+    case clang::OverloadedOperatorKind::OO_GreaterGreater:
     case clang::OverloadedOperatorKind::OO_EqualEqual:
     case clang::OverloadedOperatorKind::OO_ExclaimEqual:
     case clang::OverloadedOperatorKind::OO_LessEqual:
     case clang::OverloadedOperatorKind::OO_GreaterEqual:
+    case clang::OverloadedOperatorKind::OO_AmpAmp:
+    case clang::OverloadedOperatorKind::OO_PipePipe:
       if (auto FD = dyn_cast<clang::FunctionDecl>(D)) {
         baseName = clang::getOperatorSpelling(op);
         isFunction = true;

test/Interop/Cxx/operators/Inputs/non-member-inline.h

@@ -41,13 +41,9 @@ inline IntBox operator>>(IntBox lhs, IntBox rhs) {
   return IntBox{.value = lhs.value >> rhs.value};
 }
 
-inline bool operator<(IntBox lhs, IntBox rhs) {
-  return lhs.value < rhs.value;
-}
+inline bool operator<(IntBox lhs, IntBox rhs) { return lhs.value < rhs.value; }
 
-inline bool operator>(IntBox lhs, IntBox rhs) {
-  return lhs.value > rhs.value;
-}
+inline bool operator>(IntBox lhs, IntBox rhs) { return lhs.value > rhs.value; }
 
 inline bool operator==(IntBox lhs, IntBox rhs) {
   return lhs.value == rhs.value;

test/Interop/Cxx/operators/non-member-inline.swift

@@ -43,7 +43,7 @@ OperatorsTestSuite.test("slash (/)") {
   expectEqual(1, result.value)
 }
 
-OperatorsTestSuite.test("percent") {
+OperatorsTestSuite.test("percent (%)") {
   let lhs = IntBox(value: 11)
   let rhs = IntBox(value: 2)
 
@@ -52,7 +52,7 @@ OperatorsTestSuite.test("percent") {
   expectEqual(1, result.value)
 }
 
-OperatorsTestSuite.test("amp") {
+OperatorsTestSuite.test("amp (&)") {
   let lhs = IntBox(value: 6)
   let rhs = IntBox(value: 5)
 
@@ -61,7 +61,7 @@ OperatorsTestSuite.test("amp") {
   expectEqual(4, result.value)
 }
 
-OperatorsTestSuite.test("pipe") {
+OperatorsTestSuite.test("pipe (|)") {
   let lhs = IntBox(value: 6)
   let rhs = IntBox(value: 5)
 
@@ -70,42 +70,6 @@ OperatorsTestSuite.test("pipe") {
   expectEqual(7, result.value)
 }
 
-OperatorsTestSuite.test("less less (<<)") {
-  let lhs = IntBox(value: 2)
-  let rhs = IntBox(value: 4)
-
-  let result = lhs << rhs
-
-  expectEqual(32, result.value)
-}
-
-OperatorsTestSuite.test("greater greater (>>)") {
-  let lhs = IntBox(value: 512)
-  let rhs = IntBox(value: 8)
-
-  let result = lhs >> rhs
-
-  expectEqual(2, result.value)
-}
-
-OperatorsTestSuite.test("amp amp (&&)") {
-  let lhs = BoolBox(value: true)
-  let rhs = BoolBox(value: false)
-
-  let result = lhs && rhs
-
-  expectEqual(false, result.value)
-}
-
-OperatorsTestSuite.test("pipe pipe (||)") {
-  let lhs = BoolBox(value: true)
-  let rhs = BoolBox(value: false)
-
-  let result = lhs || rhs
-
-  expectEqual(true, result.value)
-}
-
 OperatorsTestSuite.test("less (<)") {
   let lhs = IntBox(value: 5)
   let rhs = IntBox(value: 6)
@@ -124,6 +88,24 @@ OperatorsTestSuite.test("greater (>)") {
   expectEqual(false, result)
 }
 
+OperatorsTestSuite.test("less less (<<)") {
+  let lhs = IntBox(value: 2)
+  let rhs = IntBox(value: 4)
+
+  let result = lhs << rhs
+
+  expectEqual(32, result.value)
+}
+
+OperatorsTestSuite.test("greater greater (>>)") {
+  let lhs = IntBox(value: 512)
+  let rhs = IntBox(value: 8)
+
+  let result = lhs >> rhs
+
+  expectEqual(2, result.value)
+}
+
 OperatorsTestSuite.test("equal equal (==)") {
   let lhs = IntBox(value: 5)
   let rhs = IntBox(value: 5)
@@ -160,4 +142,22 @@ OperatorsTestSuite.test("greater equal (>=)") {
   expectEqual(true, result)
 }
 
+OperatorsTestSuite.test("amp amp (&&)") {
+  let lhs = BoolBox(value: true)
+  let rhs = BoolBox(value: false)
+
+  let result = lhs && rhs
+
+  expectEqual(false, result.value)
+}
+
+OperatorsTestSuite.test("pipe pipe (||)") {
+  let lhs = BoolBox(value: true)
+  let rhs = BoolBox(value: false)
+
+  let result = lhs || rhs
+
+  expectEqual(true, result.value)
+}
+
 runAllTests()