Merge pull request #19045 from xedin/move-is-explicit-conversion-to-constraint

[ConstraintSystem] NFC: Move `isExplicitConversion` to `Constraint`

Author: xedin

lib/Sema/CSSolver.cpp

@@ -2066,7 +2066,7 @@ bool ConstraintSystem::solveForDisjunction(
 
   auto noSolutions = solveForDisjunctionChoices(
       disjunction->getNestedConstraints(), locator, solutions,
-      allowFreeTypeVariables, isExplicitConversionConstraint(disjunction));
+      allowFreeTypeVariables, disjunction->isExplicitConversion());
 
   if (hasDisabledChoices) {
     // Re-enable previously disabled overload choices.

lib/Sema/Constraint.cpp

@@ -536,6 +536,17 @@ static void uniqueTypeVariables(SmallVectorImpl<TypeVariableType *> &typeVars) {
                  typeVars.end());
 }
 
+bool Constraint::isExplicitConversion() const {
+  assert(Kind == ConstraintKind::Disjunction);
+
+  if (auto *locator = getLocator()) {
+    if (auto anchor = locator->getAnchor())
+      return isa<CoerceExpr>(anchor);
+  }
+
+  return false;
+}
+
 Constraint *Constraint::create(ConstraintSystem &cs, ConstraintKind kind, 
                                Type first, Type second,
                                ConstraintLocator *locator) {

lib/Sema/Constraint.h

@@ -583,6 +583,10 @@ class Constraint final : public llvm::ilist_node<Constraint>,
     return count;
   }
 
+  /// Determine if this constraint represents explicit conversion,
+  /// e.g. coercion constraint "as X" which forms a disjunction.
+  bool isExplicitConversion() const;
+
   /// Retrieve the overload choice for an overload-binding constraint.
   OverloadChoice getOverloadChoice() const {
     assert(Kind == ConstraintKind::BindOverload);

lib/Sema/ConstraintSystem.h

@@ -2108,20 +2108,6 @@ class ConstraintSystem {
   Type getResultType(const AbstractClosureExpr *E);
 
 private:
-  /// Determine if the given constraint represents explicit conversion,
-  /// e.g. coercion constraint "as X" which forms a disjunction.
-  bool isExplicitConversionConstraint(Constraint *constraint) const {
-    if (constraint->getKind() != ConstraintKind::Disjunction)
-      return false;
-
-    if (auto locator = constraint->getLocator()) {
-      if (auto anchor = locator->getAnchor())
-        return isa<CoerceExpr>(anchor);
-    }
-
-    return false;
-  }
-
   /// Introduce the constraints associated with the given type variable
   /// into the worklist.
   void addTypeVariableConstraintsToWorkList(TypeVariableType *typeVar);