Skip to content

Commit 3ca63c3

Browse files
Simon Gladmanstephentyrone
Simon Gladman
authored and
stephentyrone
committed
Code review changes:
* `squareRoot` -> `sqrt` * `reciprocalSquareRoot` -> `rsqrt` * `xxx(piTimes:...)` -> `xxxPi(:_....)`
1 parent 14ec828 commit 3ca63c3

File tree

2 files changed

+85
-87
lines changed

2 files changed

+85
-87
lines changed

‎stdlib/public/Darwin/Accelerate/vForce_Operations.swift

Lines changed: 50 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,6 @@
1010
//
1111
//===----------------------------------------------------------------------===//
1212

13-
import Accelerate
14-
1513
// Array-Oriented Arithmetic and Auxiliary Functions
1614

1715
extension vForce {
@@ -833,16 +831,16 @@ extension vForce {
833831
/// - Returns: Output values.
834832
@inline(__always)
835833
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
836-
public static func reciprocalSquareRoot<U>(_ vector: U) -> [Float]
834+
public static func rsqrt<U>(_ vector: U) -> [Float]
837835
where
838836
U : _ContiguousCollection,
839837
U.Element == Float {
840838

841839
let result = Array<Float>(unsafeUninitializedCapacity: vector.count) {
842840
buffer, initializedCount in
843841

844-
reciprocalSquareRoot(vector,
845-
result: &buffer)
842+
rsqrt(vector,
843+
result: &buffer)
846844

847845
initializedCount = vector.count
848846
}
@@ -856,8 +854,8 @@ extension vForce {
856854
/// - Parameter result: Output values.
857855
@inline(__always)
858856
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
859-
public static func reciprocalSquareRoot<U, V>(_ vector: U,
860-
result: inout V)
857+
public static func rsqrt<U, V>(_ vector: U,
858+
result: inout V)
861859
where
862860
U : _ContiguousCollection,
863861
V : _MutableContiguousCollection,
@@ -882,16 +880,16 @@ extension vForce {
882880
/// - Returns: Output values.
883881
@inline(__always)
884882
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
885-
public static func reciprocalSquareRoot<U>(_ vector: U) -> [Double]
883+
public static func rsqrt<U>(_ vector: U) -> [Double]
886884
where
887885
U : _ContiguousCollection,
888886
U.Element == Double {
889887

890888
let result = Array<Double>(unsafeUninitializedCapacity: vector.count) {
891889
buffer, initializedCount in
892890

893-
reciprocalSquareRoot(vector,
894-
result: &buffer)
891+
rsqrt(vector,
892+
result: &buffer)
895893

896894
initializedCount = vector.count
897895
}
@@ -905,8 +903,8 @@ extension vForce {
905903
/// - Parameter result: Output values.
906904
@inline(__always)
907905
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
908-
public static func reciprocalSquareRoot<U, V>(_ vector: U,
909-
result: inout V)
906+
public static func rsqrt<U, V>(_ vector: U,
907+
result: inout V)
910908
where
911909
U : _ContiguousCollection,
912910
V : _MutableContiguousCollection,
@@ -933,16 +931,16 @@ extension vForce {
933931
/// - Returns: Output values.
934932
@inline(__always)
935933
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
936-
public static func squareRoot<U>(_ vector: U) -> [Float]
934+
public static func sqrt<U>(_ vector: U) -> [Float]
937935
where
938936
U : _ContiguousCollection,
939937
U.Element == Float {
940938

941939
let result = Array<Float>(unsafeUninitializedCapacity: vector.count) {
942940
buffer, initializedCount in
943941

944-
squareRoot(vector,
945-
result: &buffer)
942+
sqrt(vector,
943+
result: &buffer)
946944

947945
initializedCount = vector.count
948946
}
@@ -956,8 +954,8 @@ extension vForce {
956954
/// - Parameter result: Output values.
957955
@inline(__always)
958956
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
959-
public static func squareRoot<U, V>(_ vector: U,
960-
result: inout V)
957+
public static func sqrt<U, V>(_ vector: U,
958+
result: inout V)
961959
where
962960
U : _ContiguousCollection,
963961
V : _MutableContiguousCollection,
@@ -983,16 +981,16 @@ extension vForce {
983981
/// - Returns: Output values.
984982
@inline(__always)
985983
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
986-
public static func squareRoot<U>(_ vector: U) -> [Double]
984+
public static func sqrt<U>(_ vector: U) -> [Double]
987985
where
988986
U : _ContiguousCollection,
989987
U.Element == Double {
990988

991989
let result = Array<Double>(unsafeUninitializedCapacity: vector.count) {
992990
buffer, initializedCount in
993991

994-
squareRoot(vector,
995-
result: &buffer)
992+
sqrt(vector,
993+
result: &buffer)
996994

997995
initializedCount = vector.count
998996
}
@@ -1006,8 +1004,8 @@ extension vForce {
10061004
/// - Parameter result: Output values.
10071005
@inline(__always)
10081006
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
1009-
public static func squareRoot<U, V>(_ vector: U,
1010-
result: inout V)
1007+
public static func sqrt<U, V>(_ vector: U,
1008+
result: inout V)
10111009
where
10121010
U : _ContiguousCollection,
10131011
V : _MutableContiguousCollection,
@@ -1973,16 +1971,16 @@ extension vForce {
19731971
/// - Returns: Output values.
19741972
@inline(__always)
19751973
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
1976-
public static func sin<U>(piTimes vector: U) -> [Float]
1974+
public static func sinPi<U>(_ vector: U) -> [Float]
19771975
where
19781976
U : _ContiguousCollection,
19791977
U.Element == Float {
19801978

19811979
let result = Array<Float>(unsafeUninitializedCapacity: vector.count) {
19821980
buffer, initializedCount in
19831981

1984-
sin(piTimes: vector,
1985-
result: &buffer)
1982+
sinPi(vector,
1983+
result: &buffer)
19861984

19871985
initializedCount = vector.count
19881986
}
@@ -1996,8 +1994,8 @@ extension vForce {
19961994
/// - Parameter result: Output values.
19971995
@inline(__always)
19981996
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
1999-
public static func sin<U, V>(piTimes vector: U,
2000-
result: inout V)
1997+
public static func sinPi<U, V>(_ vector: U,
1998+
result: inout V)
20011999
where
20022000
U : _ContiguousCollection,
20032001
V : _MutableContiguousCollection,
@@ -2022,16 +2020,16 @@ extension vForce {
20222020
/// - Returns: Output values.
20232021
@inline(__always)
20242022
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
2025-
public static func sin<U>(piTimes vector: U) -> [Double]
2023+
public static func sinPi<U>(_ vector: U) -> [Double]
20262024
where
20272025
U : _ContiguousCollection,
20282026
U.Element == Double {
20292027

20302028
let result = Array<Double>(unsafeUninitializedCapacity: vector.count) {
20312029
buffer, initializedCount in
20322030

2033-
sin(piTimes: vector,
2034-
result: &buffer)
2031+
sinPi(vector,
2032+
result: &buffer)
20352033

20362034
initializedCount = vector.count
20372035
}
@@ -2045,8 +2043,8 @@ extension vForce {
20452043
/// - Parameter result: Output values.
20462044
@inline(__always)
20472045
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
2048-
public static func sin<U, V>(piTimes vector: U,
2049-
result: inout V)
2046+
public static func sinPi<U, V>(_ vector: U,
2047+
result: inout V)
20502048
where
20512049
U : _ContiguousCollection,
20522050
V : _MutableContiguousCollection,
@@ -2171,16 +2169,16 @@ extension vForce {
21712169
/// - Returns: Output values.
21722170
@inline(__always)
21732171
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
2174-
public static func cos<U>(piTimes vector: U) -> [Float]
2172+
public static func cosPi<U>(_ vector: U) -> [Float]
21752173
where
21762174
U : _ContiguousCollection,
21772175
U.Element == Float {
21782176

21792177
let result = Array<Float>(unsafeUninitializedCapacity: vector.count) {
21802178
buffer, initializedCount in
21812179

2182-
cos(piTimes: vector,
2183-
result: &buffer)
2180+
cosPi(vector,
2181+
result: &buffer)
21842182

21852183
initializedCount = vector.count
21862184
}
@@ -2194,8 +2192,8 @@ extension vForce {
21942192
/// - Parameter result: Output values.
21952193
@inline(__always)
21962194
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
2197-
public static func cos<U, V>(piTimes vector: U,
2198-
result: inout V)
2195+
public static func cosPi<U, V>(_ vector: U,
2196+
result: inout V)
21992197
where
22002198
U : _ContiguousCollection,
22012199
V : _MutableContiguousCollection,
@@ -2220,16 +2218,16 @@ extension vForce {
22202218
/// - Returns: Output values.
22212219
@inline(__always)
22222220
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
2223-
public static func cos<U>(piTimes vector: U) -> [Double]
2221+
public static func cosPi<U>(_ vector: U) -> [Double]
22242222
where
22252223
U : _ContiguousCollection,
22262224
U.Element == Double {
22272225

22282226
let result = Array<Double>(unsafeUninitializedCapacity: vector.count) {
22292227
buffer, initializedCount in
22302228

2231-
cos(piTimes: vector,
2232-
result: &buffer)
2229+
cosPi(vector,
2230+
result: &buffer)
22332231

22342232
initializedCount = vector.count
22352233
}
@@ -2243,8 +2241,8 @@ extension vForce {
22432241
/// - Parameter result: Output values.
22442242
@inline(__always)
22452243
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
2246-
public static func cos<U, V>(piTimes vector: U,
2247-
result: inout V)
2244+
public static func cosPi<U, V>(_ vector: U,
2245+
result: inout V)
22482246
where
22492247
U : _ContiguousCollection,
22502248
V : _MutableContiguousCollection,
@@ -2436,16 +2434,16 @@ extension vForce {
24362434
/// - Returns: Output values.
24372435
@inline(__always)
24382436
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
2439-
public static func tan<U>(piTimes vector: U) -> [Float]
2437+
public static func tanPi<U>(_ vector: U) -> [Float]
24402438
where
24412439
U : _ContiguousCollection,
24422440
U.Element == Float {
24432441

24442442
let result = Array<Float>(unsafeUninitializedCapacity: vector.count) {
24452443
buffer, initializedCount in
24462444

2447-
tan(piTimes: vector,
2448-
result: &buffer)
2445+
tanPi(vector,
2446+
result: &buffer)
24492447

24502448
initializedCount = vector.count
24512449
}
@@ -2459,8 +2457,8 @@ extension vForce {
24592457
/// - Parameter result: Output values.
24602458
@inline(__always)
24612459
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
2462-
public static func tan<U, V>(piTimes vector: U,
2463-
result: inout V)
2460+
public static func tanPi<U, V>(_ vector: U,
2461+
result: inout V)
24642462
where
24652463
U : _ContiguousCollection,
24662464
V : _MutableContiguousCollection,
@@ -2485,16 +2483,16 @@ extension vForce {
24852483
/// - Returns: Output values.
24862484
@inline(__always)
24872485
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
2488-
public static func tan<U>(piTimes vector: U) -> [Double]
2486+
public static func tanPi<U>(_ vector: U) -> [Double]
24892487
where
24902488
U : _ContiguousCollection,
24912489
U.Element == Double {
24922490

24932491
let result = Array<Double>(unsafeUninitializedCapacity: vector.count) {
24942492
buffer, initializedCount in
24952493

2496-
tan(piTimes: vector,
2497-
result: &buffer)
2494+
tanPi(vector,
2495+
result: &buffer)
24982496

24992497
initializedCount = vector.count
25002498
}
@@ -2508,8 +2506,8 @@ extension vForce {
25082506
/// - Parameter result: Output values.
25092507
@inline(__always)
25102508
@available(iOS 9999, macOS 9999, tvOS 9999, watchOS 9999, *)
2511-
public static func tan<U, V>(piTimes vector: U,
2512-
result: inout V)
2509+
public static func tanPi<U, V>(_ vector: U,
2510+
result: inout V)
25132511
where
25142512
U : _ContiguousCollection,
25152513
V : _MutableContiguousCollection,

0 commit comments

Comments
 (0)