Skip to content

Commit 3d058c6

Browse files
committed
[Typechecker] Remove a few unnecessary isTypeContext() checks as its implifed by isInstanceMember()
1 parent d9c8ae4 commit 3d058c6

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

lib/Sema/TypeCheckDecl.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1959,9 +1959,7 @@ void TypeChecker::validateDecl(OperatorDecl *OD) {
19591959
llvm::Expected<SelfAccessKind>
19601960
SelfAccessKindRequest::evaluate(Evaluator &evaluator, FuncDecl *FD) const {
19611961
if (FD->getAttrs().getAttribute<MutatingAttr>(true)) {
1962-
auto functionDC = FD->getDeclContext();
1963-
if (!FD->isInstanceMember() ||
1964-
(functionDC->isTypeContext() && !functionDC->hasValueSemantics())) {
1962+
if (!FD->isInstanceMember() || !FD->getDeclContext()->hasValueSemantics()) {
19651963
return SelfAccessKind::NonMutating;
19661964
}
19671965
return SelfAccessKind::Mutating;
@@ -1983,9 +1981,7 @@ SelfAccessKindRequest::evaluate(Evaluator &evaluator, FuncDecl *FD) const {
19831981
case AccessorKind::MutableAddress:
19841982
case AccessorKind::Set:
19851983
case AccessorKind::Modify:
1986-
auto accessorDC = AD->getDeclContext();
1987-
if (AD->isInstanceMember() && accessorDC->isTypeContext() &&
1988-
accessorDC->hasValueSemantics())
1984+
if (AD->isInstanceMember() && AD->getDeclContext()->hasValueSemantics())
19891985
return SelfAccessKind::Mutating;
19901986
break;
19911987

0 commit comments

Comments
 (0)