SwiftCompilerSources: Fix InteriorUseWalker with visitInnerUses.

atrick · atrick · commit 406afc720217 · 2025-02-26T00:38:18.000-08:00
Add support to all kinds of borrowing instructions so we visit all their inner uses.
diff --git a/SwiftCompilerSources/Sources/Optimizer/Utilities/OwnershipLiveness.swift b/SwiftCompilerSources/Sources/Optimizer/Utilities/OwnershipLiveness.swift
@@ -608,9 +608,9 @@ extension InteriorUseWalker: OwnershipUseVisitor {
       if handleInner(borrowed: beginBorrow.value) == .abortWalk {
         return .abortWalk
       }
-      if visitInnerUses {
-        return visitAllUses(of: beginBorrow.value)
-      }
+    }
+    if visitInnerUses, let innerValue = borrowInst.innerValue {
+      return visitAllUses(of: innerValue)
     }
     return visitInnerBorrowUses(of: borrowInst, operand: operand)
   }

Original file line number	Diff line number	Diff line change
`@@ -608,9 +608,9 @@ extension InteriorUseWalker: OwnershipUseVisitor {`
`608`	`608`	`if handleInner(borrowed: beginBorrow.value) == .abortWalk {`
`609`	`609`	`return .abortWalk`
`610`	`610`	`}`
`611`		`- if visitInnerUses {`
`612`		`- return visitAllUses(of: beginBorrow.value)`
`613`		`- }`
	`611`	`+ }`
	`612`	`+ if visitInnerUses, let innerValue = borrowInst.innerValue {`
	`613`	`+ return visitAllUses(of: innerValue)`
`614`	`614`	`}`
`615`	`615`	`return visitInnerBorrowUses(of: borrowInst, operand: operand)`
`616`	`616`	`}`