Skip to content

Commit 409f553

Browse files
committed
---
yaml --- r: 323455 b: refs/heads/tensorflow-next c: a3dea72 h: refs/heads/master i: 323453: eec60c3 323451: ec05358 323447: a8bcf59 323439: 44420ad 323423: 2c4172d 323391: b74dfec 323327: 38c0cad
1 parent e9d91dd commit 409f553

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1461,4 +1461,4 @@ refs/heads/master-rebranch: 86e95c23aa0d37f24ec138b7853146c1cead2e40
14611461
refs/heads/rdar-53901732: 9bd06af3284e18a109cdbf9aa59d833b24eeca7b
14621462
refs/heads/revert-26776-subst-always-returns-a-type: 1b8e18fdd391903a348970a4c848995d4cdd789c
14631463
refs/heads/tensorflow-merge: 8b854f62f80d4476cb383d43c4aac2001dde3cec
1464-
refs/heads/tensorflow-next: 82e5aaad559137906e12c5a7cce653ede58dd0ed
1464+
refs/heads/tensorflow-next: a3dea721dc887470202d28b33496504473c7c4b9

branches/tensorflow-next/lib/Sema/CSSimplify.cpp

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2241,9 +2241,14 @@ bool ConstraintSystem::repairFailures(
22412241
*this, lhs, anchor, loc,
22422242
[&](ResolvedOverloadSetListItem *overload, VarDecl *decl,
22432243
Type newBase) {
2244-
return matchTypes(newBase, rhs, ConstraintKind::Subtype,
2245-
TypeMatchFlags::TMF_ApplyingFix,
2246-
overload->Locator)
2244+
// FIXME: There is currently no easy way to avoid attempting
2245+
// fixes, matchTypes do not propagate `TMF_ApplyingFix` flag.
2246+
llvm::SaveAndRestore<ConstraintSystemOptions> options(
2247+
Options, Options - ConstraintSystemFlags::AllowFixes);
2248+
2249+
TypeMatchOptions flags;
2250+
return matchTypes(newBase, rhs, ConstraintKind::Subtype, flags,
2251+
getConstraintLocator(locator))
22472252
.isSuccess();
22482253
},
22492254
rhs)) {

branches/tensorflow-next/test/Sanitizers/tsan-norace-deinit-run-time.swift

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
// RUN: %target-swiftc_driver %s -g -sanitize=thread %import-libdispatch -target %sanitizers-target-triple -o %t_tsan-binary
22
// RUN: %target-codesign %t_tsan-binary
3-
// RUN: env %env-TSAN_OPTIONS=abort_on_error=0 %target-run %t_tsan-binary 2>&1 | %FileCheck %s --dump-input=fail --implicit-check-not='ThreadSanitizer'
3+
// RUN: env %env-TSAN_OPTIONS=abort_on_error=0 %target-run %t_tsan-binary 2>&1 | %FileCheck %s --implicit-check-not='ThreadSanitizer'
44
// REQUIRES: executable_test
55
// REQUIRES: tsan_runtime
66

7+
// Failing sporadically in CI
8+
// REQUIRES: rdar51804988
9+
710
// FIXME: This should be covered by "tsan_runtime"; older versions of Apple OSs
811
// don't support TSan.
912
// UNSUPPORTED: remote_run

branches/tensorflow-next/test/decl/var/property_wrappers.swift

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -932,7 +932,7 @@ struct TestComposition {
932932
// Missing Property Wrapper Unwrap Diagnostics
933933
// ---------------------------------------------------------------------------
934934
@propertyWrapper
935-
struct Foo<T> {
935+
struct Foo<T> { // expected-note {{arguments to generic parameter 'T' ('W' and 'Int') are expected to be equal}}
936936
var wrappedValue: T
937937

938938
var prop: Int = 42
@@ -987,6 +987,7 @@ struct MissingPropertyWrapperUnwrap {
987987
func b(_: Foo<Int>) {}
988988
func c(_: V) {}
989989
func d(_: W) {}
990+
func e(_: Foo<W>) {}
990991

991992
func baz() {
992993
self.x.foo() // expected-error {{referencing instance method 'foo()' requires wrapper 'Foo<Int>'}}{{10-10=_}}
@@ -1005,7 +1006,10 @@ struct MissingPropertyWrapperUnwrap {
10051006

10061007
a(self.w) // expected-error {{cannot convert value 'w' of type 'W' to expected type 'Foo<W>', use wrapper instead}}{{12-12=_}}
10071008
b(self.x) // expected-error {{cannot convert value 'x' of type 'Int' to expected type 'Foo<Int>', use wrapper instead}}{{12-12=_}}
1008-
b(self.w) // expected-error {{cannot convert value 'w' of type 'W' to expected type 'Foo<Int>', use wrapper instead}}{{12-12=_}}
1009+
b(self.w) // expected-error {{cannot convert value of type 'W' to expected argument type 'Foo<Int>'}}
1010+
e(self.w) // expected-error {{cannot convert value 'w' of type 'W' to expected type 'Foo<W>', use wrapper instead}}{{12-12=_}}
1011+
b(self._w) // expected-error {{cannot convert value of type 'Foo<W>' to expected argument type 'Foo<Int>'}}
1012+
10091013
c(self.usesProjectedValue) // expected-error {{cannot convert value 'usesProjectedValue' of type 'W' to expected type 'V', use wrapper instead}}{{12-12=$}}
10101014
d(self.$usesProjectedValue) // expected-error {{cannot convert value '$usesProjectedValue' of type 'V' to expected type 'W', use wrapped value instead}}{{12-13=}}
10111015
d(self._usesProjectedValue) // expected-error {{cannot convert value '_usesProjectedValue' of type 'Baz<W>' to expected type 'W', use wrapped value instead}}{{12-13=}}

0 commit comments

Comments
 (0)