Rm doISplitAScope for visitBraceStmt

Author: David Ungar

include/swift/AST/ASTScope.h

@@ -277,13 +277,6 @@ class ASTScopeImpl {
 
 
 #pragma mark - - creation queries
-protected:
-  /// In other words, does this scope introduce a new definition
-  bool doISplitAScope() const {
-    // Before an abstract storage decl, the decl is inaccessible.
-    // After an abstract storage decl, it is now accessible.
-    return isThisAnAbstractStorageDecl();
-  }
 public:
   virtual bool isThisAnAbstractStorageDecl() const { return false; }
 

lib/AST/ASTScopeCreation.cpp

@@ -462,8 +462,8 @@ class ASTVisitorForScopeCreation
 
   ASTScopeImpl *visitBraceStmt(BraceStmt *bs, ASTScopeImpl *p,
                                ScopeCreator &scopeCreator) {
-    auto *insertionPoint = scopeCreator.createSubtree<BraceStmtScope>(p, bs);
-    return p->doISplitAScope() ? insertionPoint : p;
+    scopeCreator.createSubtree<BraceStmtScope>(p, bs);
+    return p;
   }
 
   ASTScopeImpl *visitPatternBindingDecl(PatternBindingDecl *patternBinding,