[CMake] Fix the Xcode generator

In PR 5182 I broke the Xcode generator in cases where the output path had ${CMAKE_CFG_INTDIR} in it. This broke because $(CONFIGURATION) is invalid in the name of a target.

Since all targets will have the same value for CMAKE_BINARY_DIR and CMAKE_CFG_INTDIR we can remove those from the target names and still have unique values.

This has the impact of shortening the generated target names so that the filename components are unlikely to hit OS limits using IDE generators where CMake generates Makefiles or scripts for custom commands. It also retains the debug ability that PR 5182 was attempting to add.

Author: Chris Bieneman

cmake/modules/SwiftAddCustomCommandTarget.cmake

@@ -122,7 +122,9 @@ function(add_custom_command_target dependency_out_var_name)
   if("${ACCT_CUSTOM_TARGET_NAME}" STREQUAL "")
     # CMake doesn't allow '/' characters in filenames, so replace them with '-'
     list(GET ACCT_OUTPUT 0 output_filename)
-    string(REPLACE "/" "-" target_name "${output_filename}")
+    string(REPLACE "${CMAKE_BINARY_DIR}/" "" target_name "${output_filename}")
+    string(REPLACE "${CMAKE_CFG_INTDIR}/" "" target_name "${target_name}")
+    string(REPLACE "/" "-" target_name "${target_name}")
   else()
     set(target_name "${ACCT_CUSTOM_TARGET_NAME}")
   endif()