Remove the argument to setInvalid()

Author: CodaFi

include/swift/AST/Decl.h

@@ -810,7 +810,7 @@ class alignas(1 << DeclAlignInBits) Decl {
   bool isInvalid() const { return Bits.Decl.Invalid; }
 
   /// Mark this declaration invalid.
-  void setInvalid(bool isInvalid = true) { Bits.Decl.Invalid = isInvalid; }
+  void setInvalid() { Bits.Decl.Invalid = true; }
 
   /// Determine whether this declaration was implicitly generated by the
   /// compiler (rather than explicitly written in source code).

lib/Parse/ParseDecl.cpp

@@ -4840,7 +4840,7 @@ Parser::parseDeclVarGetSet(Pattern *pattern, ParseDeclOptions Flags,
                                     VarLoc, Identifier(),
                                     CurDeclContext);
     storage->setImplicit(true);
-    storage->setInvalid(true);
+    storage->setInvalid();
 
     Pattern *pattern =
       TypedPattern::createImplicit(Context, new (Context) NamedPattern(storage),
@@ -4850,7 +4850,7 @@ Parser::parseDeclVarGetSet(Pattern *pattern, ParseDeclOptions Flags,
     auto binding = PatternBindingDecl::create(Context, StaticLoc,
                                               StaticSpelling,
                                               VarLoc, entry, CurDeclContext);
-    binding->setInvalid(true);
+    binding->setInvalid();
     storage->setParentPatternBinding(binding);
 
     Decls.push_back(binding);

lib/Sema/CSDiag.cpp

@@ -910,9 +910,6 @@ namespace {
                 P->setInterfaceType(Type());
               }
               TS->PossiblyInvalidDecls.insert(P);
-              
-              if (P->isInvalid())
-                P->setInvalid(false);
             }
 
           expr->setType(nullptr);