[CS] Remove assertion that callee locator has an anchor

ahoppen · ahoppen · commit 4201829e8ce7 · 2022-07-14T15:40:53.000+02:00
When computing type relations of code completion items with respect to the context they are used in, we add a `ConstraintKind::Conversion` constraint with an empty constraint locator. This currently crashes in `hasPreconcurrencyCallee`, but actually having a null anchor doesn’t produce any issues.
diff --git a/lib/Sema/ConstraintSystem.cpp b/lib/Sema/ConstraintSystem.cpp
@@ -481,8 +481,6 @@ ConstraintLocator *ConstraintSystem::getCalleeLocator(
     }
   }
 
-  assert(bool(anchor) && "Expected an anchor!");
-
   {
     // If we have a locator for a member found through key path dynamic member
     // lookup, then we need to chop off the elements after the

Original file line number	Diff line number	Diff line change
`@@ -481,8 +481,6 @@ ConstraintLocator *ConstraintSystem::getCalleeLocator(`
`481`	`481`	`}`
`482`	`482`	`}`
`483`	`483`
`484`		`- assert(bool(anchor) && "Expected an anchor!");`
`485`		`-`
`486`	`484`	`{`
`487`	`485`	`// If we have a locator for a member found through key path dynamic member`
`488`	`486`	`// lookup, then we need to chop off the elements after the`