Add "Legacy" to the manual referenced name tracker

Author: CodaFi

include/swift/AST/SourceFile.h

@@ -466,10 +466,10 @@ class SourceFile final : public FileUnit {
 
   virtual bool walk(ASTWalker &walker) override;
 
-  ReferencedNameTracker *getReferencedNameTracker() {
+  ReferencedNameTracker *getLegacyReferencedNameTracker() {
     return ReferencedNames ? ReferencedNames.getPointer() : nullptr;
   }
-  const ReferencedNameTracker *getReferencedNameTracker() const {
+  const ReferencedNameTracker *getLegacyReferencedNameTracker() const {
     return ReferencedNames ? ReferencedNames.getPointer() : nullptr;
   }
 

lib/AST/Module.cpp

@@ -2604,7 +2604,7 @@ SourceFile::getConfiguredReferencedNameTracker() const {
   if (getASTContext().LangOpts.EnableRequestBasedIncrementalDependencies) {
     return getRequestBasedReferencedNameTracker();
   } else {
-    return getReferencedNameTracker();
+    return getLegacyReferencedNameTracker();
   }
 }
 

lib/AST/NameLookup.cpp

@@ -715,7 +715,7 @@ void namelookup::recordLookupOfTopLevelName(DeclContext *topLevelContext,
   auto SF = dyn_cast<SourceFile>(topLevelContext);
   if (!SF)
     return;
-  auto *nameTracker = SF->getReferencedNameTracker();
+  auto *nameTracker = SF->getLegacyReferencedNameTracker();
   if (!nameTracker)
     return;
   nameTracker->addTopLevelName(name.getBaseName(), isCascading);
@@ -1381,7 +1381,7 @@ static void configureLookup(const DeclContext *dc,
   tracker = nullptr;
   if (auto containingSourceFile =
           dyn_cast<SourceFile>(dc->getModuleScopeContext())) {
-    tracker = containingSourceFile->getReferencedNameTracker();
+    tracker = containingSourceFile->getLegacyReferencedNameTracker();
   }
 
   auto checkLookupCascading = [dc, options]() -> Optional<bool> {

lib/Sema/TypeCheckDeclPrimary.cpp

@@ -492,7 +492,7 @@ CheckRedeclarationRequest::evaluate(Evaluator &eval, ValueDecl *current) const {
   if (!currentFile || currentDC->isLocalContext())
     return std::make_tuple<>();
 
-  ReferencedNameTracker *tracker = currentFile->getReferencedNameTracker();
+  ReferencedNameTracker *tracker = currentFile->getLegacyReferencedNameTracker();
   bool isCascading = (current->getFormalAccess() > AccessLevel::FilePrivate);
 
   // Find other potential definitions.
@@ -1962,7 +1962,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
         // for the superclass will run (un)qualified lookup which will register
         // the appropriate edge, then SuperclassTypeRequest registers the
         // potential member edge.
-        if (auto *tracker = SF->getReferencedNameTracker()) {
+        if (auto *tracker = SF->getLegacyReferencedNameTracker()) {
           bool isPrivate =
               CD->getFormalAccess() <= AccessLevel::FilePrivate;
           tracker->addUsedMember({Super, Identifier()}, !isPrivate);
@@ -2067,7 +2067,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
     (void)PD->hasCircularInheritedProtocols();
 
     if (SF) {
-      if (auto *tracker = SF->getReferencedNameTracker()) {
+      if (auto *tracker = SF->getLegacyReferencedNameTracker()) {
         bool isNonPrivate = (PD->getFormalAccess() > AccessLevel::FilePrivate);
         // FIXME(Evaluator Incremental Dependencies): Remove this. Type lookup
         // for the ancestor protocols will run (un)qualified lookup which will

lib/Sema/TypeCheckProtocol.cpp

@@ -3876,7 +3876,7 @@ static void recordConformanceDependency(DeclContext *DC,
   if (!SF)
     return;
 
-  auto *tracker = SF->getReferencedNameTracker();
+  auto *tracker = SF->getLegacyReferencedNameTracker();
   if (!tracker)
     return;
 
@@ -5129,7 +5129,7 @@ void TypeChecker::checkConformancesInContext(DeclContext *dc,
   SourceFile *SF = dc->getParentSourceFile();
   ReferencedNameTracker *tracker = nullptr;
   if (SF)
-    tracker = SF->getReferencedNameTracker();
+    tracker = SF->getLegacyReferencedNameTracker();
 
   // Check each of the conformances associated with this context.
   auto conformances =