Merge pull request #59124 from eeckstein/fix-perf-annotations

PerformanceDiagnostics: fix a crash when emitting a module

Author: eeckstein

lib/SILOptimizer/Mandatory/PerformanceDiagnostics.cpp

@@ -90,6 +90,9 @@ static bool isEffectFreeArraySemanticCall(SILInstruction *inst) {
 bool PerformanceDiagnostics::visitFunction(SILFunction *function,
                                               PerformanceConstraints perfConstr,
                                               LocWithParent *parentLoc) {
+  if (!function->isDefinition())
+    return false;
+
   ReachingReturnBlocks rrBlocks(function);
   NonErrorHandlingBlocks neBlocks(function);
 

test/SILOptimizer/performance-annotations-crash.swift

@@ -0,0 +1,9 @@
+// RUN: %target-swift-frontend -experimental-performance-annotations -experimental-skip-non-inlinable-function-bodies-without-types -emit-module %s -o /dev/null
+
+// Don't crash when emitting a module
+
+@_noAllocation
+func foo() -> Int {
+  return 42
+}
+print(foo())