Skip to content

Commit 44a7038

Browse files
committed
[benchmark] Address review comments on FP conversion benchmarks
1 parent 60b7c57 commit 44a7038

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

benchmark/single-source/FloatingPointConversion.swift

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,18 @@ public let FloatingPointConversion = [
1616
BenchmarkInfo(
1717
name: "ConvertFloatingPoint.ConcreteDoubleToDouble",
1818
runFunction: run_ConvertFloatingPoint_ConcreteDoubleToDouble,
19-
tags: [.validation, .api]),
19+
tags: [.validation, .api],
20+
setUpFunction: { blackHole(doubles) }),
2021
BenchmarkInfo(
2122
name: "ConvertFloatingPoint.GenericDoubleToDouble",
2223
runFunction: run_ConvertFloatingPoint_GenericDoubleToDouble,
23-
tags: [.validation, .api]),
24+
tags: [.validation, .api],
25+
setUpFunction: { blackHole(doubles) }),
2426
BenchmarkInfo(
2527
name: "ConvertFloatingPoint.MockFloat64ToDouble",
2628
runFunction: run_ConvertFloatingPoint_MockFloat64ToDouble,
27-
tags: [.validation, .api]),
29+
tags: [.validation, .api],
30+
setUpFunction: { blackHole(mockFloat64s) }),
2831
]
2932

3033
protocol MockBinaryFloatingPoint: BinaryFloatingPoint {
@@ -125,11 +128,6 @@ extension MockBinaryFloatingPoint {
125128
mutating func round(_ rule: FloatingPointRoundingRule) { _value.round(rule) }
126129
}
127130

128-
struct MockFloat32: MockBinaryFloatingPoint {
129-
var _value: Float
130-
init(_ _value: Float) { self._value = _value }
131-
}
132-
133131
struct MockFloat64: MockBinaryFloatingPoint {
134132
var _value: Double
135133
init(_ _value: Double) { self._value = _value }

0 commit comments

Comments
 (0)