Merge pull request #38234 from lorentey/revert-unowned-executor-diagnostic-downgrade-5.5

[5.5][Sema] Revert temporary downgrade of diagnostic on misplaced unownedExecutor

Author: lorentey

include/swift/AST/DiagnosticsSema.def

@@ -4372,10 +4372,7 @@ ERROR(actor_protocol_illegal_inheritance,none,
       "non-actor type %0 cannot conform to the 'Actor' protocol",
       (DeclName))
 
-// FIXME: This diagnostic was temporarily downgraded from an error because
-// it spuriously triggers when building the Foundation module from its textual
-// swiftinterface. (rdar://78932296)
-WARNING(unowned_executor_outside_actor,none,
+ERROR(unowned_executor_outside_actor,none,
       "'unownedExecutor' can only be implemented within the main "
       "definition of an actor", ())
 ERROR(override_implicit_unowned_executor,none,

lib/Sema/TypeCheckProtocol.cpp

@@ -4584,10 +4584,7 @@ void ConformanceChecker::resolveValueWitnesses() {
           Adoptee->getClassOrBoundGenericClass() &&
           Adoptee->getClassOrBoundGenericClass()->isActor()) {
         witness->diagnose(diag::unowned_executor_outside_actor);
-        // FIXME: This diagnostic was temporarily downgraded from an error to a
-        // warning because it spuriously triggers when building the Foundation
-        // module from its textual swiftinterface. (rdar://78932296)
-        //return;
+        return;
       }
 
       // Objective-C checking for @objc requirements.