---

yaml
---
r: 343539
b: refs/heads/master-rebranch
c: 7277f4f
h: refs/heads/master
i:
  343537: b01a587
  343535: 02c6ab9

Author: hborla

[refs]

@@ -1455,7 +1455,7 @@ refs/tags/swift-DEVELOPMENT-SNAPSHOT-2019-08-02-a: ddd2b2976aa9bfde5f20fe37f6bd2
 refs/tags/swift-DEVELOPMENT-SNAPSHOT-2019-08-03-a: 171cc166f2abeb5ca2a4003700a8a78a108bd300
 refs/heads/benlangmuir-patch-1: baaebaf39d52f3bf36710d4fe40cf212e996b212
 refs/heads/i-do-redeclare: 8c4e6d5de5c1e3f0a2cedccf319df713ea22c48e
-refs/heads/master-rebranch: 0b7772d32b1f9cfddfbb42aea28c71a2f8350e3f
+refs/heads/master-rebranch: 7277f4f4ed4d1a3463d73d325f0845f37c1ffe2f
 refs/heads/rdar-53901732: 9bd06af3284e18a109cdbf9aa59d833b24eeca7b
 refs/heads/revert-26776-subst-always-returns-a-type: 1b8e18fdd391903a348970a4c848995d4cdd789c
 refs/heads/tensorflow-merge: 8b854f62f80d4476cb383d43c4aac2001dde3cec

branches/master-rebranch/docs/ABI/Mangling.rst

@@ -551,11 +551,6 @@ Types
   type ::= assoc-type-name 'Qz'                      // shortcut for 'Qyz'
   type ::= assoc-type-list 'QY' GENERIC-PARAM-INDEX  // associated type at depth
   type ::= assoc-type-list 'QZ'                      // shortcut for 'QYz'
-  
-  #if SWIFT_RUNTIME_VERSION >= 5.2
-    type ::= type assoc-type-name 'Qx' // associated type relative to base `type`
-    type ::= type assoc-type-list 'QX' // associated type relative to base `type`
-  #endif
 
   protocol-list ::= protocol '_' protocol*
   protocol-list ::= empty-list

branches/master-rebranch/include/swift/AST/ASTContext.h

@@ -17,6 +17,7 @@
 #ifndef SWIFT_AST_ASTCONTEXT_H
 #define SWIFT_AST_ASTCONTEXT_H
 
+#include "swift/AST/ClangModuleLoader.h"
 #include "swift/AST/Evaluator.h"
 #include "swift/AST/GenericSignature.h"
 #include "swift/AST/Identifier.h"
@@ -31,7 +32,6 @@
 #include "llvm/ADT/MapVector.h"
 #include "llvm/ADT/PointerIntPair.h"
 #include "llvm/ADT/SetVector.h"
-#include "llvm/ADT/SmallPtrSet.h"
 #include "llvm/ADT/StringMap.h"
 #include "llvm/ADT/TinyPtrVector.h"
 #include "llvm/Support/Allocator.h"
@@ -49,12 +49,10 @@ namespace clang {
 }
 
 namespace swift {
-  class AbstractFunctionDecl;
   class ASTContext;
   enum class Associativity : unsigned char;
   class AvailabilityContext;
   class BoundGenericType;
-  class ClangModuleLoader;
   class ClangNode;
   class ConcreteDeclRef;
   class ConstructorDecl;

branches/master-rebranch/include/swift/AST/ASTNode.h

@@ -36,10 +36,10 @@ namespace swift {
   enum class DeclKind : uint8_t;
   enum class StmtKind;
 
-  struct ASTNode : public llvm::PointerUnion<Expr*, Stmt*, Decl*> {
+  struct ASTNode : public llvm::PointerUnion3<Expr*, Stmt*, Decl*> {
     // Inherit the constructors from PointerUnion.
-    using PointerUnion::PointerUnion;
-
+    using PointerUnion3::PointerUnion3;
+    
     SourceRange getSourceRange() const;
 
     /// Return the location of the start of the statement.

branches/master-rebranch/include/swift/AST/ASTTypeIDZone.def

@@ -19,7 +19,6 @@ SWIFT_TYPEID_NAMED(VarDecl *, VarDecl)
 SWIFT_TYPEID_NAMED(ValueDecl *, ValueDecl)
 SWIFT_TYPEID_NAMED(ProtocolDecl *, ProtocolDecl)
 SWIFT_TYPEID_NAMED(Decl *, Decl)
-SWIFT_TYPEID_NAMED(ModuleDecl *, ModuleDecl)
 SWIFT_TYPEID(Type)
 SWIFT_TYPEID(TypePair)
 SWIFT_TYPEID(PropertyWrapperBackingPropertyInfo)

branches/master-rebranch/include/swift/AST/ASTTypeIDs.h

@@ -26,7 +26,6 @@ class Decl;
 class GenericSignature;
 class GenericTypeParamType;
 class IterableDeclContext;
-class ModuleDecl;
 class NominalTypeDecl;
 class OperatorDecl;
 struct PropertyWrapperBackingPropertyInfo;

branches/master-rebranch/include/swift/AST/AccessRequests.h

@@ -75,15 +75,14 @@ class SetterAccessLevelRequest :
   void cacheResult(AccessLevel value) const;
 };
 
-using DefaultAndMax = std::pair<AccessLevel, AccessLevel>;
-
 /// Request the Default and Max AccessLevels of the given ExtensionDecl.
 class DefaultAndMaxAccessLevelRequest :
     public SimpleRequest<DefaultAndMaxAccessLevelRequest,
-                         DefaultAndMax(ExtensionDecl *),
+                         std::pair<AccessLevel, AccessLevel>(ExtensionDecl *),
                          CacheKind::SeparatelyCached> {
 public:
   using SimpleRequest::SimpleRequest;
+  using DefaultAndMax = std::pair<AccessLevel, AccessLevel>;
 private:
   friend SimpleRequest;
 
@@ -105,7 +104,7 @@ class DefaultAndMaxAccessLevelRequest :
 #undef SWIFT_TYPEID_HEADER
 
 // Set up reporting of evaluated requests.
-#define SWIFT_REQUEST(Zone, RequestType, Sig, Caching)                         \
+#define SWIFT_REQUEST(Zone, RequestType)                         \
 template<>                                                       \
 inline void reportEvaluatedRequest(UnifiedStatsReporter &stats,  \
                             const RequestType &request) {        \

branches/master-rebranch/include/swift/AST/AccessTypeIDZone.def

@@ -15,9 +15,6 @@
 //
 //===----------------------------------------------------------------------===//
 
-SWIFT_REQUEST(AccessControl, AccessLevelRequest, AccessLevel(ValueDecl *),
-              SeparatelyCached)
-SWIFT_REQUEST(AccessControl, DefaultAndMaxAccessLevelRequest,
-              DefaultAndMax(ExtensionDecl *), SeparatelyCached)
-SWIFT_REQUEST(AccessControl, SetterAccessLevelRequest,
-              AccessLevel(AbstractStorageDecl *), SeparatelyCached)
+SWIFT_REQUEST(AccessControl, AccessLevelRequest)
+SWIFT_REQUEST(AccessControl, DefaultAndMaxAccessLevelRequest)
+SWIFT_REQUEST(AccessControl, SetterAccessLevelRequest)

branches/master-rebranch/include/swift/AST/Decl.h

@@ -543,7 +543,7 @@ class alignas(1 << DeclAlignInBits) Decl {
     NumRequirementsInSignature : 16
   );
 
-  SWIFT_INLINE_BITFIELD(ClassDecl, NominalTypeDecl, 2+1+2+1+7+1+1+1+1+1+1,
+  SWIFT_INLINE_BITFIELD(ClassDecl, NominalTypeDecl, 2+1+2+1+7+1+1+1+1,
     /// The stage of the inheritance circularity check for this class.
     Circularity : 2,
 
@@ -557,10 +557,7 @@ class alignas(1 << DeclAlignInBits) Decl {
     HasForcedEmittedMembers : 1,     
 
     HasMissingDesignatedInitializers : 1,
-    ComputedHasMissingDesignatedInitializers : 1,
-
     HasMissingVTableEntries : 1,
-    ComputedHasMissingVTableEntries : 1,
 
     /// Whether instances of this class are incompatible
     /// with weak and unowned references.
@@ -1428,7 +1425,7 @@ class GenericParamList final :
   /// to the given DeclContext.
   GenericParamList *clone(DeclContext *dc) const;
 
-  void print(raw_ostream &OS) const;
+  void print(raw_ostream &OS);
   void dump();
 };
 
@@ -3275,7 +3272,7 @@ class NominalTypeDecl : public GenericTypeDecl, public IterableDeclContext {
   llvm::PointerIntPair<MemberLookupTable *, 1, bool> LookupTable;
 
   /// Prepare the lookup table to make it ready for lookups.
-  void prepareLookupTable();
+  void prepareLookupTable(bool ignoreNewExtensions);
 
   /// True if the entries in \c LookupTable are complete--that is, if a
   /// name is present, it contains all members with that name.
@@ -3381,11 +3378,24 @@ class NominalTypeDecl : public GenericTypeDecl, public IterableDeclContext {
   /// Retrieve the set of extensions of this type.
   ExtensionRange getExtensions();
 
+  /// Make a member of this nominal type, or one of its extensions,
+  /// immediately visible in the lookup table.
+  ///
+  /// A member of a nominal type or extension thereof will become
+  /// visible to name lookup as soon as it is added. However, if the
+  /// addition of a member is delayed---for example, because it's
+  /// being introduced in response to name lookup---this method can be
+  /// called to make it immediately visible.
+  void makeMemberVisible(ValueDecl *member);
+
   /// Special-behaviour flags passed to lookupDirect()
   enum class LookupDirectFlags {
+    /// Whether to avoid loading any new extension.
+    /// Used by the module loader to break recursion.
+    IgnoreNewExtensions = 1 << 0,
     /// Whether to include @_implements members.
     /// Used by conformance-checking to find special @_implements members.
-    IncludeAttrImplements = 1 << 0,
+    IncludeAttrImplements = 1 << 1,
   };
 
   /// Find all of the declarations with the given name within this nominal type
@@ -3869,7 +3879,6 @@ class ClassDecl final : public NominalTypeDecl {
   bool hasMissingDesignatedInitializers() const;
 
   void setHasMissingDesignatedInitializers(bool newValue = true) {
-    Bits.ClassDecl.ComputedHasMissingDesignatedInitializers = 1;
     Bits.ClassDecl.HasMissingDesignatedInitializers = newValue;
   }
 
@@ -3880,7 +3889,6 @@ class ClassDecl final : public NominalTypeDecl {
   bool hasMissingVTableEntries() const;
 
   void setHasMissingVTableEntries(bool newValue = true) {
-    Bits.ClassDecl.ComputedHasMissingVTableEntries = 1;
     Bits.ClassDecl.HasMissingVTableEntries = newValue;
   }
 
@@ -4187,14 +4195,6 @@ class ProtocolDecl final : public NominalTypeDecl {
   /// a protocol having nested types (ObjC protocols).
   llvm::TinyPtrVector<AssociatedTypeDecl *> getAssociatedTypeMembers() const;
 
-  /// Returns a protocol requirement with the given name, or nullptr if the
-  /// name has multiple overloads, or no overloads at all.
-  ValueDecl *getSingleRequirement(DeclName name) const;
-
-  /// Returns an associated type with the given name, or nullptr if one does
-  /// not exist.
-  AssociatedTypeDecl *getAssociatedType(Identifier name) const;
-
   /// Walk this protocol and all of the protocols inherited by this protocol,
   /// transitively, invoking the callback function for each protocol.
   ///
@@ -4338,7 +4338,7 @@ class ProtocolDecl final : public NominalTypeDecl {
   /// with the Objective-C runtime.
   StringRef getObjCRuntimeName(llvm::SmallVectorImpl<char> &buffer) const;
 
-  /// Create the generic parameters of this protocol if they haven't been
+  /// Create the generic parameters of this protocol if the haven't been
   /// created yet.
   void createGenericParamsIfMissing();
 
@@ -4789,7 +4789,7 @@ class VarDecl : public AbstractStorageDecl {
   };
 
 protected:
-  PointerUnion<PatternBindingDecl *, Stmt *, VarDecl *> Parent;
+  PointerUnion3<PatternBindingDecl *, Stmt *, VarDecl *> Parent;
 
   VarDecl(DeclKind kind, bool isStatic, Introducer introducer,
           bool issCaptureList, SourceLoc nameLoc, Identifier name,
@@ -7261,9 +7261,6 @@ inline void simple_display(llvm::raw_ostream &out,
   simple_display(out, static_cast<const Decl *>(decl));
 }
 
-/// Display GenericParamList.
-void simple_display(llvm::raw_ostream &out, const GenericParamList *GPL);
-
 /// Extract the source location from the given declaration.
 SourceLoc extractNearestSourceLoc(const Decl *decl);
 

branches/master-rebranch/include/swift/AST/DiagnosticsClangImporter.def

@@ -91,6 +91,10 @@ WARNING(implicit_bridging_header_imported_from_module,none,
         "is deprecated and will be removed in a later version of Swift",
         (StringRef, Identifier))
 
+WARNING(clang_vfs_overlay_is_ignored,none,
+        "ignoring '-ivfsoverlay' options provided to '-Xcc' in favor of "
+        "'-vfsoverlay'", ())
+
 #ifndef DIAG_NO_UNDEF
 # if defined(DIAG)
 #  undef DIAG

branches/master-rebranch/include/swift/AST/GenericSignatureBuilder.h

@@ -92,10 +92,10 @@ class GenericSignatureBuilder {
   class ResolvedType;
 
   using UnresolvedRequirementRHS =
-      llvm::PointerUnion<Type, PotentialArchetype *, LayoutConstraint>;
+      llvm::PointerUnion3<Type, PotentialArchetype *, LayoutConstraint>;
 
   using RequirementRHS =
-    llvm::PointerUnion<Type, PotentialArchetype *, LayoutConstraint>;
+    llvm::PointerUnion3<Type, PotentialArchetype *, LayoutConstraint>;
 
   /// The location of a requirement as written somewhere in the source.
   typedef llvm::PointerUnion<const TypeRepr *, const RequirementRepr *>
@@ -615,6 +615,7 @@ class GenericSignatureBuilder {
   /// because the type \c Dictionary<K,V> cannot be formed without it.
   void inferRequirements(ModuleDecl &module,
                          Type type,
+                         const TypeRepr *typeRepr,
                          FloatingRequirementSource source);
 
   /// Infer requirements from the given pattern, recursively.
@@ -1373,8 +1374,8 @@ class GenericSignatureBuilder::FloatingRequirementSource {
   } kind;
 
   using Storage =
-    llvm::PointerUnion<const RequirementSource *, const TypeRepr *,
-                       const RequirementRepr *>;
+    llvm::PointerUnion3<const RequirementSource *, const TypeRepr *,
+                        const RequirementRepr *>;
 
   Storage storage;
 

branches/master-rebranch/include/swift/AST/ModuleLoader.h

@@ -24,10 +24,6 @@
 #include "llvm/ADT/SmallSet.h"
 #include "llvm/ADT/TinyPtrVector.h"
 
-namespace llvm {
-class FileCollector;
-}
-
 namespace clang {
 class DependencyCollector;
 }
@@ -58,9 +54,8 @@ enum class Bridgeability : unsigned {
 class DependencyTracker {
   std::shared_ptr<clang::DependencyCollector> clangCollector;
 public:
-  explicit DependencyTracker(
-      bool TrackSystemDeps,
-      std::shared_ptr<llvm::FileCollector> FileCollector = {});
+
+  explicit DependencyTracker(bool TrackSystemDeps);
 
   /// Adds a file as a dependency.
   ///

branches/master-rebranch/include/swift/AST/NameLookupRequests.h

@@ -265,7 +265,7 @@ template<typename Request>
 void reportEvaluatedRequest(UnifiedStatsReporter &stats,
                             const Request &request);
 
-#define SWIFT_REQUEST(Zone, RequestType, Sig, Caching)                         \
+#define SWIFT_REQUEST(Zone, RequestType)                         \
 template<>                                                       \
 inline void reportEvaluatedRequest(UnifiedStatsReporter &stats,  \
                             const RequestType &request) {        \

branches/master-rebranch/include/swift/AST/NameLookupTypeIDZone.def

@@ -15,22 +15,12 @@
 //
 //===----------------------------------------------------------------------===//
 
-SWIFT_REQUEST(NameLookup, CustomAttrNominalRequest,
-              NominalTypeDecl *(CustomAttr *, DeclContext *), Cached)
-SWIFT_REQUEST(NameLookup, ExtendedNominalRequest,
-              NominalTypeDecl *(ExtensionDecl *), SeparatelyCached)
-SWIFT_REQUEST(NameLookup, GetDestructorRequest, DestructorDecl *(ClassDecl *),
-              SeparatelyCached)
-SWIFT_REQUEST(NameLookup, InheritedDeclsReferencedRequest,
-              DirectlyReferencedTypeDecls(
-                  llvm::PointerUnion<TypeDecl *, ExtensionDecl *>, unsigned),
-              Uncached)
-SWIFT_REQUEST(NameLookup, SelfBoundsFromWhereClauseRequest,
-              SelfBounds(llvm::PointerUnion<TypeDecl *, ExtensionDecl *>),
-              Uncached)
-SWIFT_REQUEST(NameLookup, SuperclassDeclRequest, ClassDecl *(NominalTypeDecl *),
-              SeparatelyCached)
-SWIFT_REQUEST(NameLookup, TypeDeclsFromWhereClauseRequest,
-              DirectlyReferencedTypeDecls(ExtensionDecl *), Uncached)
-SWIFT_REQUEST(NameLookup, UnderlyingTypeDeclsReferencedRequest,
-              DirectlyReferencedTypeDecls(TypeAliasDecl *), Uncached)
+SWIFT_REQUEST(NameLookup, CustomAttrNominalRequest)
+SWIFT_REQUEST(NameLookup, ExtendedNominalRequest)
+SWIFT_REQUEST(NameLookup, GetDestructorRequest)
+SWIFT_REQUEST(NameLookup, InheritedDeclsReferencedRequest)
+SWIFT_REQUEST(NameLookup, SelfBoundsFromWhereClauseRequest)
+SWIFT_REQUEST(NameLookup, SuperclassDeclRequest)
+SWIFT_REQUEST(NameLookup, TypeDeclsFromWhereClauseRequest)
+SWIFT_REQUEST(NameLookup, UnderlyingTypeDeclsReferencedRequest)
+

branches/master-rebranch/include/swift/AST/ParseRequests.h

@@ -78,7 +78,7 @@ class ParseAbstractFunctionBodyRequest :
 #undef SWIFT_TYPEID_HEADER
 
 // Set up reporting of evaluated requests.
-#define SWIFT_REQUEST(Zone, RequestType, Sig, Caching)           \
+#define SWIFT_REQUEST(Zone, RequestType)                         \
 template<>                                                       \
 inline void reportEvaluatedRequest(UnifiedStatsReporter &stats,  \
                             const RequestType &request) {        \

branches/master-rebranch/include/swift/AST/ParseTypeIDZone.def

@@ -14,7 +14,5 @@
 //
 //===----------------------------------------------------------------------===//
 
-SWIFT_REQUEST(Parse, ParseMembersRequest,
-              ArrayRef<Decl *>(IterableDeclContext *), Cached)
-SWIFT_REQUEST(Parse, ParseAbstractFunctionBodyRequest,
-              BraceStmt *(AbstractFunctionDecl *), SeparatelyCached)
+SWIFT_REQUEST(Parse, ParseMembersRequest)
+SWIFT_REQUEST(Parse, ParseAbstractFunctionBodyRequest)