Skip to content

Commit 46309d9

Browse files
committed
[Runtime] Rename swift_unknown* functions to swift_unknownObject*.
These functions don't accept local variable heap memory, although the names make it sound like they work on anything. When you try, they mistakenly identify such things as ObjC objects, call through to the equivalent objc_* function, and crash confusingly. This adds Object to the name of each one to make it more clear what they accept. rdar://problem/37285743
1 parent e8dc505 commit 46309d9

33 files changed

+707
-687
lines changed

docs/Runtime.md

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -110,28 +110,28 @@ Returns a random number. Only used by allocation profiling tools.
110110
000000000001ce50 T _swift_retain_n
111111
000000000001d140 T _swift_tryPin
112112
000000000001d240 T _swift_tryRetain
113-
0000000000027b10 T _swift_unknownRelease
114-
0000000000027a70 T _swift_unknownRelease_n
115-
0000000000027ad0 T _swift_unknownRetain
116-
0000000000027a10 T _swift_unknownRetain_n
117-
0000000000027d50 T _swift_unknownUnownedAssign
118-
00000000000280a0 T _swift_unknownUnownedCopyAssign
119-
0000000000027fd0 T _swift_unknownUnownedCopyInit
120-
0000000000027ed0 T _swift_unknownUnownedDestroy
121-
0000000000027cb0 T _swift_unknownUnownedInit
122-
0000000000027f20 T _swift_unknownUnownedLoadStrong
123-
00000000000281f0 T _swift_unknownUnownedTakeAssign
124-
0000000000028070 T _swift_unknownUnownedTakeInit
125-
0000000000027f70 T _swift_unknownUnownedTakeStrong
126-
00000000000282b0 T _swift_unknownWeakAssign
127-
0000000000028560 T _swift_unknownWeakCopyAssign
128-
00000000000284e0 T _swift_unknownWeakCopyInit
129-
00000000000283e0 T _swift_unknownWeakDestroy
130-
0000000000028270 T _swift_unknownWeakInit
131-
0000000000028420 T _swift_unknownWeakLoadStrong
132-
0000000000028610 T _swift_unknownWeakTakeAssign
133-
0000000000028520 T _swift_unknownWeakTakeInit
134-
0000000000028470 T _swift_unknownWeakTakeStrong
113+
0000000000027b10 T _swift_unknownObjectRelease
114+
0000000000027a70 T _swift_unknownObjectRelease_n
115+
0000000000027ad0 T _swift_unknownObjectRetain
116+
0000000000027a10 T _swift_unknownObjectRetain_n
117+
0000000000027d50 T _swift_unknownObjectUnownedAssign
118+
00000000000280a0 T _swift_unknownObjectUnownedCopyAssign
119+
0000000000027fd0 T _swift_unknownObjectUnownedCopyInit
120+
0000000000027ed0 T _swift_unknownObjectUnownedDestroy
121+
0000000000027cb0 T _swift_unknownObjectUnownedInit
122+
0000000000027f20 T _swift_unknownObjectUnownedLoadStrong
123+
00000000000281f0 T _swift_unknownObjectUnownedTakeAssign
124+
0000000000028070 T _swift_unknownObjectUnownedTakeInit
125+
0000000000027f70 T _swift_unknownObjectUnownedTakeStrong
126+
00000000000282b0 T _swift_unknownObjectWeakAssign
127+
0000000000028560 T _swift_unknownObjectWeakCopyAssign
128+
00000000000284e0 T _swift_unknownObjectWeakCopyInit
129+
00000000000283e0 T _swift_unknownObjectWeakDestroy
130+
0000000000028270 T _swift_unknownObjectWeakInit
131+
0000000000028420 T _swift_unknownObjectWeakLoadStrong
132+
0000000000028610 T _swift_unknownObjectWeakTakeAssign
133+
0000000000028520 T _swift_unknownObjectWeakTakeInit
134+
0000000000028470 T _swift_unknownObjectWeakTakeStrong
135135
000000000001d3c0 T _swift_unownedCheck
136136
000000000001cfb0 T _swift_unownedRelease
137137
000000000001d0a0 T _swift_unownedRelease_n

0 commit comments

Comments
 (0)