Skip to content

Commit 481d09a

Browse files
committed
Avoid std::min with static const arguments
1 parent c42e15e commit 481d09a

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

stdlib/public/Reflection/TypeLowering.cpp

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1791,9 +1791,10 @@ class EnumTypeInfoBuilder {
17911791
/* Size */ 2, /* Alignment */ 2, /* Stride */ 2,
17921792
/* NumExtraInhabitants */ 65536 - NoPayloadCases, Cases);
17931793
} else {
1794-
auto extraInhabitants = std::min(
1795-
ValueWitnessFlags::MaxNumExtraInhabitants,
1796-
std::numeric_limits<uint32_t>::max() - NoPayloadCases + 1);
1794+
auto extraInhabitants = std::numeric_limits<uint32_t>::max() - NoPayloadCases + 1;
1795+
if (extraInhabitants > ValueWitnessFlags::MaxNumExtraInhabitants) {
1796+
extraInhabitants = ValueWitnessFlags::MaxNumExtraInhabitants;
1797+
}
17971798
return TC.makeTypeInfo<NoPayloadEnumTypeInfo>(
17981799
/* Size */ 4, /* Alignment */ 4, /* Stride */ 4,
17991800
/* NumExtraInhabitants */ extraInhabitants, Cases);
@@ -1883,8 +1884,9 @@ class EnumTypeInfoBuilder {
18831884
} else {
18841885
NumExtraInhabitants =
18851886
(1 << (tagCounts.numTagBytes * 8)) - tagCounts.numTags;
1886-
NumExtraInhabitants = std::min(NumExtraInhabitants,
1887-
unsigned(ValueWitnessFlags::MaxNumExtraInhabitants));
1887+
if (NumExtraInhabitants > ValueWitnessFlags::MaxNumExtraInhabitants) {
1888+
NumExtraInhabitants = ValueWitnessFlags::MaxNumExtraInhabitants;
1889+
}
18881890
}
18891891
unsigned Stride = ((Size + Alignment - 1) & ~(Alignment - 1));
18901892
if (Stride == 0)

0 commit comments

Comments
 (0)