Remove effect annotations from types that don't currently use them

Author: Catfish-Man

stdlib/public/core/ArraySlice.swift

@@ -856,7 +856,6 @@ extension ArraySlice: RangeReplaceableCollection {
 
   @inlinable
   @_semantics("array.make_mutable")
-  @_effects(notEscaping self.**)
   internal mutating func _makeUniqueAndReserveCapacityIfNotUnique() {
     if _slowPath(!_buffer.beginCOWMutation()) {
       _copyToNewBuffer(oldCount: _buffer.count)
@@ -865,7 +864,6 @@ extension ArraySlice: RangeReplaceableCollection {
 
   @inlinable
   @_semantics("array.mutate_unknown")
-  @_effects(notEscaping self.**)
   internal mutating func _reserveCapacityAssumingUniqueBuffer(oldCount: Int) {
     // Due to make_mutable hoisting the situation can arise where we hoist
     // _makeMutableAndUnique out of loop and use it to replace
@@ -886,7 +884,6 @@ extension ArraySlice: RangeReplaceableCollection {
 
   @inlinable
   @_semantics("array.mutate_unknown")
-  @_effects(notEscaping self.**)
   internal mutating func _appendElementAssumeUniqueAndCapacity(
     _ oldCount: Int,
     newElement: __owned Element
@@ -921,7 +918,6 @@ extension ArraySlice: RangeReplaceableCollection {
   ///   same array.
   @inlinable
   @_semantics("array.append_element")
-  @_effects(notEscaping self.value**)
   public mutating func append(_ newElement: __owned Element) {
     _makeUniqueAndReserveCapacityIfNotUnique()
     let oldCount = _getCount()
@@ -948,7 +944,6 @@ extension ArraySlice: RangeReplaceableCollection {
   ///   array.
   @_alwaysEmitIntoClient
   @_semantics("array.append_contentsOf")
-  @_effects(notEscaping self.value**)
   public mutating func append(contentsOf newElements: __owned some Collection<Element>) {
     let newElementsCount = newElements.count
     // This check prevents a data race writing to _swiftEmptyArrayStorage
@@ -990,7 +985,6 @@ extension ArraySlice: RangeReplaceableCollection {
   ///   array.
   @inlinable
   @_semantics("array.append_contentsOf")
-  @_effects(notEscaping self.value**)
   public mutating func append<S: Sequence>(contentsOf newElements: __owned S)
     where S.Element == Element {
 
@@ -1037,7 +1031,6 @@ extension ArraySlice: RangeReplaceableCollection {
 
   @inlinable
   @_semantics("array.reserve_capacity_for_append")
-  @_effects(notEscaping self.**)
   internal mutating func reserveCapacityForAppend(newElementsCount: Int) {
     let oldCount = self.count
     let oldCapacity = self.capacity

stdlib/public/core/ContiguousArray.swift

@@ -740,7 +740,6 @@ extension ContiguousArray: RangeReplaceableCollection {
 
   @inlinable
   @_semantics("array.make_mutable")
-  @_effects(notEscaping self.**)
   internal mutating func _makeUniqueAndReserveCapacityIfNotUnique() {
     if _slowPath(!_buffer.beginCOWMutation()) {
       _createNewBuffer(bufferIsUnique: false,
@@ -751,7 +750,6 @@ extension ContiguousArray: RangeReplaceableCollection {
 
   @inlinable
   @_semantics("array.mutate_unknown")
-  @_effects(notEscaping self.**)
   internal mutating func _reserveCapacityAssumingUniqueBuffer(oldCount: Int) {
     // Due to make_mutable hoisting the situation can arise where we hoist
     // _makeMutableAndUnique out of loop and use it to replace
@@ -774,7 +772,6 @@ extension ContiguousArray: RangeReplaceableCollection {
 
   @inlinable
   @_semantics("array.mutate_unknown")
-  @_effects(notEscaping self.**)
   internal mutating func _appendElementAssumeUniqueAndCapacity(
     _ oldCount: Int,
     newElement: __owned Element
@@ -808,7 +805,6 @@ extension ContiguousArray: RangeReplaceableCollection {
   /// - Complexity: O(1) on average, over many calls to `append(_:)` on the
   ///   same array.
   @inlinable
-  @_effects(notEscaping self.value**)
   @_semantics("array.append_element")
   public mutating func append(_ newElement: __owned Element) {
     // Separating uniqueness check and capacity check allows hoisting the
@@ -837,7 +833,6 @@ extension ContiguousArray: RangeReplaceableCollection {
   ///   `newElements`, over many calls to `append(contentsOf:)` on the same
   ///   array.
   @_alwaysEmitIntoClient
-  @_effects(notEscaping self.value**)
   @_semantics("array.append_contentsOf")
   public mutating func append(
     contentsOf newElements: __owned some Collection<Element>
@@ -882,7 +877,6 @@ extension ContiguousArray: RangeReplaceableCollection {
   ///   `newElements`, over many calls to `append(contentsOf:)` on the same
   ///   array.
   @inlinable
-  @_effects(notEscaping self.value**)
   @_semantics("array.append_contentsOf")
   public mutating func append<S: Sequence>(contentsOf newElements: __owned S)
     where S.Element == Element {
@@ -945,7 +939,6 @@ extension ContiguousArray: RangeReplaceableCollection {
   }
 
   @inlinable
-  @_effects(notEscaping self.value**)
   @_semantics("array.reserve_capacity_for_append")
   internal mutating func reserveCapacityForAppend(newElementsCount: Int) {
     // Ensure uniqueness, mutability, and sufficient storage.  Note that