[Serialization] Remove serialization code for initializes() and accesses() attributes

Author: LucianoPAlmeida

lib/Serialization/Deserialization.cpp

@@ -5584,36 +5584,6 @@ llvm::Error DeclDeserializer::deserializeDeclCommon() {
         break;
       }
 
-      case decls_block::Initializes_DECL_ATTR: {
-        ArrayRef<uint64_t> rawPropertyIDs;
-        serialization::decls_block::InitializesDeclAttrLayout::
-            readRecord(scratch, rawPropertyIDs);
-
-        SmallVector<Identifier, 4> properties;
-        for (auto rawID : rawPropertyIDs) {
-          properties.push_back(MF.getIdentifier(rawID));
-        }
-
-        Attr = InitializesAttr::create(ctx, SourceLoc(), SourceRange(),
-                                       properties);
-        break;
-      }
-
-      case decls_block::Accesses_DECL_ATTR: {
-        ArrayRef<uint64_t> rawPropertyIDs;
-        serialization::decls_block::AccessesDeclAttrLayout::
-            readRecord(scratch, rawPropertyIDs);
-
-        SmallVector<Identifier, 4> properties;
-        for (auto rawID : rawPropertyIDs) {
-          properties.push_back(MF.getIdentifier(rawID));
-        }
-
-        Attr = AccessesAttr::create(ctx, SourceLoc(), SourceRange(),
-                                    properties);
-        break;
-      }
-
       case decls_block::StorageRestrictions_DECL_ATTR: {
         unsigned numInitializesProperties;
         ArrayRef<uint64_t> rawPropertyIDs;

lib/Serialization/ModuleFormat.h

@@ -58,7 +58,7 @@ const uint16_t SWIFTMODULE_VERSION_MAJOR = 0;
 /// describe what change you made. The content of this comment isn't important;
 /// it just ensures a conflict if two people change the module format.
 /// Don't worry about adhering to the 80-column limit for this line.
-const uint16_t SWIFTMODULE_VERSION_MINOR = 802; // added tuple_pack_extract
+const uint16_t SWIFTMODULE_VERSION_MINOR = 803; // removed initializes and accesses attributes
 
 /// A standard hash seed used for all string hashes in a serialized module.
 ///
@@ -2233,16 +2233,6 @@ namespace decls_block {
       BCArray<IdentifierIDField> // target function pieces, spi groups, type erased params
       >;
 
-  using InitializesDeclAttrLayout = BCRecordLayout<
-      Initializes_DECL_ATTR,
-      BCArray<IdentifierIDField> // initialized properties
-  >;
-
-  using AccessesDeclAttrLayout = BCRecordLayout<
-      Accesses_DECL_ATTR,
-      BCArray<IdentifierIDField> // initialized properties
-  >;
-
   using StorageRestrictionsDeclAttrLayout = BCRecordLayout<
       StorageRestrictions_DECL_ATTR,
       BCVBR<16>, // num "initializes" properties

lib/Serialization/Serialization.cpp

@@ -2923,34 +2923,6 @@ class Serializer::DeclSerializer : public DeclVisitor<DeclSerializer> {
       return;
     }
 
-    case DAK_Initializes: {
-      auto abbrCode = S.DeclTypeAbbrCodes[InitializesDeclAttrLayout::Code];
-      auto attr = cast<InitializesAttr>(DA);
-
-      SmallVector<IdentifierID, 4> properties;
-      for (auto identifier : attr->getProperties()) {
-        properties.push_back(S.addDeclBaseNameRef(identifier));
-      }
-
-      InitializesDeclAttrLayout::emitRecord(
-          S.Out, S.ScratchRecord, abbrCode, properties);
-      return;
-    }
-
-    case DAK_Accesses: {
-      auto abbrCode = S.DeclTypeAbbrCodes[AccessesDeclAttrLayout::Code];
-      auto attr = cast<InitializesAttr>(DA);
-
-      SmallVector<IdentifierID, 4> properties;
-      for (auto identifier : attr->getProperties()) {
-        properties.push_back(S.addDeclBaseNameRef(identifier));
-      }
-
-      AccessesDeclAttrLayout::emitRecord(
-          S.Out, S.ScratchRecord, abbrCode, properties);
-      return;
-    }
-
     case DAK_StorageRestrictions: {
       auto abbrCode = S.DeclTypeAbbrCodes[StorageRestrictionsDeclAttrLayout::Code];
       auto attr = cast<StorageRestrictionsAttr>(DA);