[SIL] Verified addr usage of end_borrow.

Author: nate-chandler

lib/SIL/Verifier/SILVerifier.cpp

@@ -2243,6 +2243,10 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
     require(
         F.hasOwnership(),
         "Inst with qualified ownership in a function that is not qualified");
+    if (EBI->getOperand()->getType().isAddress()) {
+      require(isa<StoreBorrowInst>(EBI->getOperand()),
+              "end_borrow of an address not produced by store_borrow");
+    }
   }
 
   void checkEndLifetimeInst(EndLifetimeInst *I) {

test/SIL/verifier_failures.sil

@@ -0,0 +1,20 @@
+// RUN: %target-sil-opt -emit-sorted-sil -verify-continue-on-failure -o /dev/null %s 2>&1 | %FileCheck %s
+// REQUIRES: asserts
+
+sil_stage canonical
+
+import Builtin
+import Swift
+import SwiftShims
+
+class C {}
+
+// CHECK:      Begin Error in function end_borrow_1_addr_alloc_stack
+// CHECK-NEXT: SIL verification failed: end_borrow of an address not produced by store_borrow
+sil [ossa] @end_borrow_1_addr_alloc_stack : $@convention(thin) () -> () {
+  %addr = alloc_stack $C
+  end_borrow %addr : $*C
+  dealloc_stack %addr : $*C
+  %retval = tuple ()
+  return %retval : $()
+}