Merge pull request #6319 from CodaFi/crashendo-decrashendo

Actually improve recovery when parsing bogus expressions

Author: slavapestov

lib/Parse/ParseExpr.cpp

@@ -661,7 +661,7 @@ ParserResult<Expr> Parser::parseExprSelector() {
     if (Tok.is(tok::r_paren))
       rParenLoc = consumeToken();
     else
-      rParenLoc = Tok.getLoc();
+      rParenLoc = PreviousLoc;
   } else {
     parseMatchingToken(tok::r_paren, rParenLoc,
                        diag::expr_selector_expected_rparen, lParenLoc);

lib/Parse/ParsePattern.cpp

@@ -901,8 +901,8 @@ parseOptionalPatternTypeAnnotation(ParserResult<Pattern> result,
     return result;
 
   Pattern *P;
-  if (result.isNull())  // Recover by creating AnyPattern.
-    P = new (Context) AnyPattern(Tok.getLoc());
+  if (result.isNull())
+    return nullptr;
   else
     P = result.get();
 

validation-test/compiler_crashers/28522-anonymous-namespace-verifier-walktostmtpost-swift-stmt.swift renamed to validation-test/compiler_crashers_fixed/28522-anonymous-namespace-verifier-walktostmtpost-swift-stmt.swift

@@ -5,6 +5,6 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 let f=[.A{#if8
 guard let:

validation-test/compiler_crashers/28523-child-source-range-not-contained-within-its-parent-sequence-expr-type-null.swift renamed to validation-test/compiler_crashers_fixed/28523-child-source-range-not-contained-within-its-parent-sequence-expr-type-null.swift

@@ -5,5 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 (t=#selector(

validation-test/compiler_crashers/28551-anonymous-namespace-verifier-walktostmtpost-swift-stmt.swift renamed to validation-test/compiler_crashers_fixed/28551-anonymous-namespace-verifier-walktostmtpost-swift-stmt.swift

@@ -5,5 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 #if#selector(struct r

validation-test/compiler_crashers/28557-swift-astvisitor-anonymous-namespace-printtyperepr-void-void-void-void-void-void.swift renamed to validation-test/compiler_crashers_fixed/28557-swift-astvisitor-anonymous-namespace-printtyperepr-void-void-void-void-void-void.swift

@@ -5,5 +5,5 @@
 // See https://swift.org/LICENSE.txt for license information
 // See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
 
-// RUN: not --crash %target-swift-frontend %s -emit-ir
+// RUN: not %target-swift-frontend %s -emit-ir
 #if#selector(var E{unsafeAddress{